Commit Graph
6 Commits
Author SHA1 Message Date
Dario LipicarandClaude Opus 4.8 a644be2669 fix(qml-bridge): serialize results via the canonical converter (#17)
serializeResultForTesting used QJsonValue::fromVariant, which cannot
convert the custom LogosResult metatype and silently degraded a
`result`-type return to the literal "null". A QML-only ui_qml plugin
calling a result-returning method through logos.callModule therefore
received null instead of {success, value, error}.

Replace the bespoke serialization with logos-protocol's canonical
logos::qvariantToNlohmann — the same converter every transport
(lp/std/cdylib) already uses. Now ALL types round-trip to QML/JS
identically: scalars as bare literals, containers preserved, integers
kept as integers (QJsonValue::fromVariant degraded them to double),
bytes in the tagged {"_bytes":...} form, and LogosResult as
{success, value, error} (empty error -> null). Fixes both sync
callModule and async callModuleAsync.

Adds test_logos_qml_bridge_result.cpp (regression) plus the
reproduction/isolation harnesses (e2e, gui, handshake, 2-process) built
while proving the long-suspected QML "sequential-call stall" is NOT an
SDK defect: every layer round-trips correctly under isolation, and the
only real bug was this result serialization.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-21 14:37:24 -03:00
Dario LipicarandClaude Opus 4.8 710270c193 Retarget to the qt-split SDK stack (logos-qt-sdk + logos-protocol) (#11)
* Retarget to the qt-split SDK stack (logos-qt-sdk + logos-protocol)

logos-cpp-sdk::logos_sdk no longer exists after the Qt split: the Qt
developer layer (LogosAPI, provider objects) moved to logos-qt-sdk and
the transport/consumer core into the logos-protocol library. Both
targets (the static runtime lib and ui-host) now link
logos-qt-sdk::logos_qt_sdk (which carries logos-protocol transitively)
plus the header-only logos-cpp-sdk::logos_headers.

flake.nix gains logos-protocol/logos-qt-sdk inputs threaded through
nix/{default,test}.nix; the lock pins the extraction-chain branch revs
(temporary — re-lock against masters when the chain merges).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* lock: bump cpp-sdk to the qt-free branch head with the protocol lock fix

This flake declares no follows between logos-cpp-sdk and logos-protocol,
so cpp-sdk's OWN lock governs its nested protocol; b86ff877 still pinned
the P1 protocol rev, which no longer compiles (LogosProviderPlugin moved
in the qt split). 7272c73 carries the corrected pin. Temporary — drop
when the chain merges.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(tests): retarget the unit-test link to the qt-split SDK targets

tests/CMakeLists.txt still linked bare logos_sdk (only built with
LOGOS_VIEW_RUNTIME_BUILD_TESTS=ON, so the package build verified earlier
missed it). The runtime lib's PUBLIC link interface already carries the
qt-sdk/protocol targets; the explicit entries replace the dead archive.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* lock: qt-split chain fully merged — pins advance to masters (cpp-sdk 87abcd8, protocol 9de4165, qt-sdk 8d0e5d9)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 23:58:19 -03:00
Khushboo Mehta d611d697bf Revert "fix: handle long module names"
This reverts commit 1b35afb543.
2026-04-17 15:09:42 +02:00
Khushboo Mehta 1b35afb543 fix: handle long module names 2026-04-17 13:56:59 +02:00
Khushboo Mehta 5fcf427b49 feat: let qml only apps subscribe and listen to events from core modules 2026-04-14 15:04:35 +02:00
Khushboo Mehta d9fa197f87 feat: add src headers and flake files needed 2026-04-08 22:27:19 +02:00