From 342b0269febabdf540b735c3d2d84ac3203b08f5 Mon Sep 17 00:00:00 2001 From: Dario Gabriel Lipicar Date: Wed, 22 Jul 2026 15:33:42 -0300 Subject: [PATCH] fix(doctests): raise launch_timeout for the `nix run .` UI tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tutorial doc-test went red on ubuntu with inspector not available on port 3768 after 120s with `building '...-logos-standalone-app-1.0.0.drv'` as the last line of the launch log: the app was still compiling when the clock ran out. The runner pre-builds `nix run .` as `nix build .`, which is packages.default — the UI plugin. But `nix run .` launches apps.default, the standalone app, whose closure (logos-standalone-app plus the bundled backend modules) is not covered by that warm build, so it compiles during launch and is charged against the default 120s inspector wait. Give the three `nix run` UI tests the same launch_timeout the logos-wallet-module spec already uses for exactly this reason. Nothing here is rendered into the generated Markdown. Co-Authored-By: Claude Opus 4.8 --- tests/tutorial-cpp-ui-app.test.yaml | 4 ++++ tests/tutorial-qml-ui-app.test.yaml | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/tests/tutorial-cpp-ui-app.test.yaml b/tests/tutorial-cpp-ui-app.test.yaml index ef3b18f..4f4c153 100644 --- a/tests/tutorial-cpp-ui-app.test.yaml +++ b/tests/tutorial-cpp-ui-app.test.yaml @@ -787,6 +787,10 @@ sections: setup: - "nix build 'github:logos-co/logos-qt-mcp{release}' -o result-mcp" qt_mcp: "result-mcp" + # `nix build .` (the runner's warm-up) builds the UI plugin, not + # `apps.default`'s standalone-app closure, so that still compiles + # during launch and can blow past the default 120s inspector wait. + launch_timeout: 900 tests: - name: "App window opens with title" action: wait_for diff --git a/tests/tutorial-qml-ui-app.test.yaml b/tests/tutorial-qml-ui-app.test.yaml index d479141..301b436 100644 --- a/tests/tutorial-qml-ui-app.test.yaml +++ b/tests/tutorial-qml-ui-app.test.yaml @@ -378,6 +378,13 @@ sections: setup: - "nix build 'github:logos-co/logos-qt-mcp{release}' -o result-mcp" qt_mcp: "result-mcp" + # The runner pre-builds `nix build .` — that is `packages.default` + # (the UI plugin). But `nix run .` launches `apps.default`, the + # standalone app, whose closure (logos-standalone-app + the bundled + # backend modules) is NOT covered by that warm build, so it compiles + # during launch. On a cold cache that exceeds the default 120s + # inspector wait and the app never boots before we give up. + launch_timeout: 900 tests: - name: "App window opens with title" action: wait_for @@ -446,6 +453,9 @@ sections: setup: - "nix build 'github:logos-co/logos-qt-mcp{release}' -o result-mcp" qt_mcp: "result-mcp" + # Overriding calc_module rebuilds the standalone app closure, which + # the `nix build` warm-up does not cover — see the note in Step 5. + launch_timeout: 900 tests: - name: "App title visible" action: wait_for