mirror of
https://github.com/logos-co/logos-protocol.git
synced 2026-08-27 12:01:15 +00:00
Acquiring a QtRO replica per call (acquireDynamic + waitForSource) is expensive:
under a tight loop — e.g. a proxy forwarding every method to its target, or a UI
backend driving a whole surface — it dominates and can even starve the nested
synchronous calls. Cache the LogosObject handle per object name in m_objectCache
and reuse it across calls (both the sync invokeRemoteMethod and the async
invokeRemoteMethodAsync paths); no per-call release(). A stale handle (source
went away — module unloaded / transport dropped) is detected via a new
LogosObject::isValid() (QtRO replica state == Valid) and transparently
re-acquired. The cache is released in clearObjectCache() from the destructor and
before reconnect().
- logos_object.h: add virtual bool isValid() (default true).
- qt_remote/remote_transport.{h,cpp}: RemoteLogosObject::isValid() (replica
Valid state) + a process-wide acquireCount() test hook.
- logos_api_consumer.{h,cpp}: m_objectCache + acquireCachedObject()/
clearObjectCache(); sync + async reuse the cached handle; async keeps the
QPointer guard and never releases the shared handle from its callback.
Test: RemoteEventTest.ConsumerReusesCachedHandleAcrossSyncAndAsyncCalls publishes
a provider over the qt_remote host, does 12 sync + 12 async echo calls, and
asserts every result is correct AND acquireCount() == 1 (one replica for all 24
calls). 164/164 green.
169 lines
7.3 KiB
C++
169 lines
7.3 KiB
C++
#ifndef LOGOS_API_CONSUMER_H
|
|
#define LOGOS_API_CONSUMER_H
|
|
|
|
#include <QObject>
|
|
#include <QString>
|
|
#include <QVariant>
|
|
#include <QVariantList>
|
|
#include <QHash>
|
|
#include <QMap>
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "logos_call_error.h"
|
|
#include "logos_mode.h"
|
|
#include "logos_transport_config.h"
|
|
|
|
class LogosTransportConnection;
|
|
class LogosObject;
|
|
class TokenManager;
|
|
|
|
/**
|
|
* @brief LogosAPIConsumer handles connecting to module objects and invoking their methods
|
|
*
|
|
* This class is responsible for the consumer/client side functionality:
|
|
* - Connecting to module registries via the transport layer
|
|
* - Requesting LogosObject handles
|
|
* - Invoking methods on objects
|
|
* - Handling events from objects
|
|
*/
|
|
class LogosAPIConsumer : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
/**
|
|
* @brief Construct a consumer connected via `transport`, honoring the
|
|
* process-wide LogosMode.
|
|
*
|
|
* Transport resolution is done in one place — LogosTransportFactory —
|
|
* by combining LogosMode + the supplied LogosTransportConfig:
|
|
* - LogosMode::Mock → MockTransportConnection (transport ignored)
|
|
* - LogosMode::Local → LocalTransportConnection (transport ignored)
|
|
* - LogosMode::Remote → wire protocol picked by `transport.protocol`
|
|
*
|
|
* Use this overload when the caller wants a specific transport for
|
|
* this consumer without side-effecting the rest of the process
|
|
* (e.g. the logoscore CLI dialing `core_service` over tcp_ssl
|
|
* without also flipping the in-process LogosAPIProvider into
|
|
* binding TLS).
|
|
*/
|
|
LogosAPIConsumer(const QString& module_to_talk_to,
|
|
const QString& origin_module,
|
|
TokenManager* token_manager,
|
|
const LogosTransportConfig& transport,
|
|
QObject *parent = nullptr);
|
|
|
|
/**
|
|
* @brief Convenience constructor that uses the process-global default
|
|
* LogosTransportConfig. Equivalent to passing
|
|
* `LogosTransportConfigGlobal::getDefault()` to the explicit-transport
|
|
* constructor above.
|
|
*/
|
|
explicit LogosAPIConsumer(const QString& module_to_talk_to,
|
|
const QString& origin_module,
|
|
TokenManager* token_manager,
|
|
QObject *parent = nullptr);
|
|
~LogosAPIConsumer();
|
|
|
|
/**
|
|
* @brief Request a LogosObject handle by name
|
|
* @return LogosObject* handle, or nullptr if failed. Caller must call release() when done.
|
|
*/
|
|
LogosObject* requestObject(const QString& objectName, Timeout timeout = Timeout());
|
|
|
|
bool isConnected() const;
|
|
QString registryUrl() const;
|
|
bool reconnect();
|
|
|
|
QVariant invokeRemoteMethod(const QString& authToken, const QString& objectName, const QString& methodName,
|
|
const QVariantList& args = QVariantList(), Timeout timeout = Timeout());
|
|
|
|
/**
|
|
* @brief invokeRemoteMethod with an explicit error out-channel.
|
|
*
|
|
* Fills *err with the canonical {code, message, origin} call error when
|
|
* the failure is detectable on this side (today: "object_unavailable"
|
|
* when the target object/replica cannot be acquired). On success *err is
|
|
* cleared. Failures the transport cannot yet distinguish from a void
|
|
* result (per-dispatch errors) leave *err clear — the struct is the
|
|
* extension point for surfacing transport-level statuses later.
|
|
*/
|
|
QVariant invokeRemoteMethod(const QString& authToken, const QString& objectName, const QString& methodName,
|
|
const QVariantList& args, Timeout timeout, logos::CallError* err);
|
|
|
|
using AsyncResultCallback = std::function<void(QVariant)>;
|
|
|
|
/**
|
|
* @brief Async result callback with an explicit error channel.
|
|
*
|
|
* Mirrors the sync `invokeRemoteMethod(..., CallError*)` overload:
|
|
* the callback receives the same {code, message, origin} error struct,
|
|
* so callers can distinguish "the module's source could not be acquired"
|
|
* from "the call ran but returned an invalid QVariant". On success the
|
|
* error is cleared (ok() == true).
|
|
*/
|
|
using AsyncResultErrorCallback = std::function<void(QVariant, const logos::CallError&)>;
|
|
|
|
/**
|
|
* @brief Invoke a remote method asynchronously; result is delivered via callback
|
|
* @param authToken Authentication token for the operation
|
|
* @param objectName The name of the remote object
|
|
* @param methodName The name of the method to call
|
|
* @param args Arguments to pass to the method
|
|
* @param callback Called when the call completes (on the caller's thread via QueuedConnection)
|
|
* @param timeout Timeout for replica acquisition and for the remote call
|
|
*/
|
|
void invokeRemoteMethodAsync(const QString& authToken, const QString& objectName, const QString& methodName,
|
|
const QVariantList& args,
|
|
AsyncResultCallback callback,
|
|
Timeout timeout = Timeout());
|
|
|
|
/**
|
|
* @brief invokeRemoteMethodAsync with an explicit error out-channel.
|
|
*
|
|
* Sets the CallError to code="object_unavailable" when acquire fails
|
|
* (matching the sync overload's semantics — see logos_call_error.h),
|
|
* cleared on success. Callers that need to react to acquire failure
|
|
* differently from "call returned no value" should use this overload.
|
|
*/
|
|
void invokeRemoteMethodAsync(const QString& authToken, const QString& objectName, const QString& methodName,
|
|
const QVariantList& args,
|
|
AsyncResultErrorCallback callback,
|
|
Timeout timeout = Timeout());
|
|
|
|
/**
|
|
* @brief Register an event listener via LogosObject's callback mechanism
|
|
* @param originObject The LogosObject that will emit the event
|
|
* @param eventName The name of the event to listen for
|
|
* @param callback Function to call when the event is triggered
|
|
*/
|
|
void onEvent(LogosObject* originObject, const QString& eventName,
|
|
std::function<void(const QString&, const QVariantList&)> callback);
|
|
|
|
public slots:
|
|
bool informModuleToken(const QString& authToken, const QString& moduleName, const QString& token);
|
|
bool informModuleToken_module(const QString& authToken, const QString& originModule, const QString& moduleName, const QString& token);
|
|
std::string requestModule(const std::string& authToken, const std::string& originModule, const std::string& targetModule);
|
|
|
|
private:
|
|
// Get a cached remote-object handle for objectName, (re)acquiring via the
|
|
// transport if absent or stale. Acquiring a QtRO replica (acquireDynamic +
|
|
// waitForSource) is expensive, so invokeRemoteMethod reuses one handle per
|
|
// object instead of acquiring + release()ing on every call.
|
|
LogosObject* acquireCachedObject(const QString& objectName, int timeoutMs);
|
|
// Release and drop every cached handle (destructor / reconnect).
|
|
void clearObjectCache();
|
|
|
|
std::unique_ptr<LogosTransportConnection> m_transport;
|
|
QString m_registryUrl;
|
|
QMap<QString, QString> m_tokens;
|
|
TokenManager* m_token_manager;
|
|
// Object-handle cache keyed by object name. Single-threaded: touched only on
|
|
// the consumer's event-loop thread.
|
|
QHash<QString, LogosObject*> m_objectCache;
|
|
};
|
|
|
|
#endif // LOGOS_API_CONSUMER_H
|