3 Commits

Include renames

Author	SHA1	Message	Date
Dario LipicarandClaude Opus 4.8	b0c6f75498	fix(qt_remote): defer async completion delivery off the QtRO read stack (#7) ... A `concurrency:"multi"` call's result comes back as a deferred completion event (`__logos_call_complete__`), delivered by RemoteEventHelper::onEventResponse — a slot fired by the replica's eventResponse signal. Cross-process, that slot runs on QtRO's read stack (QRemoteObjectNodePrivate::onClientRead). Until now the async user callback was invoked *inline* there, and that callback routinely (a) emits a module event — which the host-side ModuleProxy serializes onto the QtRO source — and (b) release()s the client object. Doing either while onClientRead is still unwinding re-enters QtRO and corrupts the node: a SIGSEGV in onClientRead (EXC_BAD_ACCESS, KERN_INVALID_ADDRESS at 0x80). This is the crash the EVM wallet backend hit from refresh_balances, which fans balance reads out to eth_rpc via call_async and then emits `balances_updated` from the gather completion. Primary fix (remote_transport.cpp): deliver the async completion callback on the next event-loop turn via QTimer::singleShot(0, m_helper, …) instead of inline, so all user code (event emits, release(), further calls) runs after onClientRead has fully unwound. m_helper is the context so the callback is dropped if the object is torn down first. Defense-in-depth for the same re-entrancy class: - remote_transport.cpp release()/disconnectEvents()/dtor: deleteLater() the helper (signal receiver) and replica (signal sender) and disconnect first, instead of deleting them inline — deleting a QObject mid-emission corrupts the connection list Qt is iterating. - module_proxy.cpp: always queue the source eventResponse emit to the owning thread (Qt::QueuedConnection), never emit inline, so a module that emits from inside a same-thread dispatch can't re-enter QtRO's source serialization. Tests (tests/protocol/test_remote_transport_events.cpp, newly wired): qt_remote LocalSocket event delivery (direct + full provider chain) and a reentrant-release regression that drives release() from inside a deferred-completion callback. The hard crash only reproduces cross-process (in-process QtRO posts the event, so the read stack has already unwound) — the cross-process guard is the wallet Anvil integration doctest, where this fix is A/B-proven: the published backend crashes on refresh_balances, the patched backend returns balances cleanly. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-23 22:54:41 +02:00
Dario Lipicar	9de4165ab6	Qt split + module authoring groundwork: LogosProviderPlugin + the common module-impl C ABI (#3) ... * Extract the Logos protocol layer from logos-cpp-sdk Transports (plain TCP/TLS, qt_local, qt_remote/QRO, mock), token manager, consumer core (LogosAPIClient/LogosAPIConsumer incl. the capability auto-requestModule flow), ModuleProxy, the abstract LogosProviderObject interface, and the canonical QVariant<->JSON conversion — now behind the language-neutral lp_* C ABI (logos_protocol.h) carrying the protocol semver (LOGOS_PROTOCOL_VERSION_*, lp_protocol_version()). Bytes crossing the ABI use the lossless {"_bytes": base64url} tagging (NUL-safe), matching the plain wire encoding. Provider lp_* surface is compiled groundwork; serving lands with module authoring. * Move LogosProviderPlugin into logos_provider_interface.h Plugin-loading tools (logos-cpp-generator's introspection mode, lm, the hosts) need only qobject_cast<LogosProviderPlugin*>() + the abstract LogosProviderObject — both framework-internal. Hosting the detection interface here keeps those tools off the developer-facing logos-qt-sdk layer. Same iid (org.logos.LogosProviderPlugin); header-only, ABI-neutral. * Define the common module-impl C ABI (logos_module_impl.h) ONE cdylib contract for module implementations in every language: dispatch / get_methods / set_context / set_emit_callback / accept_token / get_protocol_version / string_free. The C++ and Rust SDKs emit these exports around their respective impls; the uniform generated Qt glue (and later a no-Qt host) talks to the cdylib only through this ABI. JSON data model and tagged bytes form match the lp_* consumer ABI; the protocol-version handshake complements the build-time metadata stamp. * json convert: integers stay integers across the C ABI QJsonValue::fromVariant degrades every numeric to double, so Int/UInt/ LongLong/ULongLong QVariants serialized as 5.0 — and a strict consumer on the other side of the C ABI (a generated dispatch reading an int param) rejects or zeroes them. Surfaced by the first cdylib-authored module whose inbound args cross qvariantToNlohmann; the dlopen smoke harness fed hand-written int JSON and never exercised this edge. * call-error channel: surface {code,message,origin} for unacquirable targets invokeRemoteMethod could not distinguish a failed call from a void/null result — lp_invoke returned LP_OK with a null JSON result even when the target module was never reached, and generated typed wrappers silently defaulted (0 / empty string). Additive err-out overloads on LogosAPIConsumer/LogosAPIClient fill a std-only logos::CallError (logos_call_error.h, new LogosCallError exception for the generated wrappers to throw); lp_invoke now honors its documented contract for this class of failure: LP_ERR_UNAVAILABLE + canonical error JSON. First detectable code: object_unavailable (requestObject failure) — the struct is the extension point for transport-level statuses. * call-error: drop the exception type — the error channel is the out-param Per review, generated wrappers expose CallError as an optional trailing out-parameter instead of throwing; the struct is the whole contract. * ci: build + run the protocol test suite On every pull request (unfiltered — stacked PRs included), master pushes, and manual dispatch. The repo shipped without CI; its 111-test suite only ran locally and through the workspace gate. * consumer: typed requestModule for the capability flow Port of logos-cpp-sdk master f5a127dd ('use updated capability module', cpp-sdk#85, Iuri Matias) — the touched files (logos_api_client.cpp, logos_api_consumer.{h,cpp}) moved into this repo in the P1 extraction. The capability auto-requestModule path now calls a typed std::string helper on the consumer (which acquires the capability object directly) instead of a stringly invokeRemoteMethod round-trip. 111/111 tests. * ci: DeterminateSystems nix installer (macOS runners) cachix/install-nix-action fails on the macOS runners with eDSRecordAlreadyExists (pre-existing nix build users); the org's macOS-bearing workflows use the DeterminateSystems installer.	2026-06-12 19:39:57 -03:00
Dario Lipicar	29afbac532	Extract the Logos protocol layer from logos-cpp-sdk (lp_* C ABI + protocol semver) (#2) ... * Extract the Logos protocol layer from logos-cpp-sdk Transports (plain TCP/TLS, qt_local, qt_remote/QRO, mock), token manager, consumer core (LogosAPIClient/LogosAPIConsumer incl. the capability auto-requestModule flow), ModuleProxy, the abstract LogosProviderObject interface, and the canonical QVariant<->JSON conversion — now behind the language-neutral lp_* C ABI (logos_protocol.h) carrying the protocol semver (LOGOS_PROTOCOL_VERSION_*, lp_protocol_version()). Bytes crossing the ABI use the lossless {"_bytes": base64url} tagging (NUL-safe), matching the plain wire encoding. Provider lp_* surface is compiled groundwork; serving lands with module authoring. * consumer: typed requestModule for the capability flow Port of logos-cpp-sdk master f5a127dd ('use updated capability module', cpp-sdk#85, Iuri Matias) — the touched files (logos_api_client.cpp, logos_api_consumer.{h,cpp}) moved into this repo in the P1 extraction. The capability auto-requestModule path now calls a typed std::string helper on the consumer (which acquires the capability object directly) instead of a stringly invokeRemoteMethod round-trip. 111/111 tests.	2026-06-12 18:59:01 -03:00