// Unit tests for DeliveryModuleImpl. // All liblogosdelivery C functions are mocked at link time via mock_liblogosdelivery.cpp. // Mocks invoke callbacks synchronously so the semaphore inside api_call_handler.h // is released before try_acquire_for starts waiting. #include #include "delivery_module_plugin.h" #include "mocks/delivery_module_events_stub.h" // --------------------------------------------------------------------------- // Helper: create an impl that has a valid delivery context (createNode called). // --------------------------------------------------------------------------- static DeliveryModuleImpl* createInitializedImpl(LogosTestContext& t) { t.mockCFunction("logosdelivery_create_node").returns(1); auto* impl = new DeliveryModuleImpl(); LOGOS_ASSERT_TRUE(impl->createNode(R"({"logLevel":"INFO"})").success); return impl; } // createNode LOGOS_TEST(createNode_succeeds_when_ffi_returns_non_null_context) { auto t = LogosTestContext("delivery_module"); t.mockCFunction("logosdelivery_create_node").returns(1); DeliveryModuleImpl impl; LOGOS_ASSERT_TRUE(impl.createNode(R"({"logLevel":"INFO"})").success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_create_node")); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_add_event_listener")); } LOGOS_TEST(createNode_fails_when_ffi_returns_null) { auto t = LogosTestContext("delivery_module"); t.mockCFunction("logosdelivery_create_node").returns(0); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.createNode(R"({"logLevel":"INFO"})").success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_create_node")); } LOGOS_TEST(createNode_tracks_call_count) { auto t = LogosTestContext("delivery_module"); t.mockCFunction("logosdelivery_create_node").returns(1); DeliveryModuleImpl impl; impl.createNode(R"({"logLevel":"INFO"})"); LOGOS_ASSERT_EQ(t.cFunctionCallCount("logosdelivery_create_node"), 1); } LOGOS_TEST(createNode_succeeds_with_logos_dev_preset_config) { auto t = LogosTestContext("delivery_module"); t.mockCFunction("logosdelivery_create_node").returns(1); DeliveryModuleImpl impl; LOGOS_ASSERT_TRUE(impl.createNode(R"({"logLevel":"DEBUG","mode":"Core","preset":"logos.dev"})").success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_create_node")); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_add_event_listener")); } // start LOGOS_TEST(start_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.start().success); } LOGOS_TEST(start_succeeds_after_createNode) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); LOGOS_ASSERT_TRUE(impl->start().success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_start_node")); delete impl; } LOGOS_TEST(start_calls_ffi_start_node) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); impl->start(); LOGOS_ASSERT_EQ(t.cFunctionCallCount("logosdelivery_start_node"), 1); delete impl; } // stop LOGOS_TEST(stop_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.stop().success); } LOGOS_TEST(stop_succeeds_after_createNode) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); LOGOS_ASSERT_TRUE(impl->stop().success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_stop_node")); delete impl; } // start()/stop() report completion via events LOGOS_TEST(start_emits_node_started_event) { auto t = LogosTestContext("delivery_module"); delivery_test_events::resetNodeLifecycleEvents(); auto* impl = createInitializedImpl(t); // Dispatch succeeds; the mock fires the completion callback synchronously, // so the nodeStarted event is observable right after start() returns. LOGOS_ASSERT_TRUE(impl->start().success); LOGOS_ASSERT_TRUE(delivery_test_events::g_lastNodeStarted.fired); LOGOS_ASSERT_TRUE(delivery_test_events::g_lastNodeStarted.success); delete impl; } LOGOS_TEST(stop_emits_node_stopped_event) { auto t = LogosTestContext("delivery_module"); delivery_test_events::resetNodeLifecycleEvents(); auto* impl = createInitializedImpl(t); LOGOS_ASSERT_TRUE(impl->stop().success); LOGOS_ASSERT_TRUE(delivery_test_events::g_lastNodeStopped.fired); LOGOS_ASSERT_TRUE(delivery_test_events::g_lastNodeStopped.success); delete impl; } LOGOS_TEST(start_returns_false_when_dispatch_fails) { auto t = LogosTestContext("delivery_module"); delivery_test_events::resetNodeLifecycleEvents(); auto* impl = createInitializedImpl(t); // A non-zero dispatch code means the library refused to start; start() // reports failure immediately and NO completion event is emitted. t.mockCFunction("logosdelivery_start_node").returns(1); LOGOS_ASSERT_FALSE(impl->start().success); LOGOS_ASSERT_FALSE(delivery_test_events::g_lastNodeStarted.fired); delete impl; } LOGOS_TEST(stop_returns_false_when_dispatch_fails) { auto t = LogosTestContext("delivery_module"); delivery_test_events::resetNodeLifecycleEvents(); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_stop_node").returns(1); LOGOS_ASSERT_FALSE(impl->stop().success); LOGOS_ASSERT_FALSE(delivery_test_events::g_lastNodeStopped.fired); delete impl; } // send LOGOS_TEST(send_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; std::vector payload{'h','e','l','l','o'}; StdLogosResult result = impl.send("/test/1/delivery/proto", payload); LOGOS_ASSERT_FALSE(result.success); } LOGOS_TEST(send_succeeds_and_returns_request_id) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_send").returns("req-id-abc123"); std::vector payload{'h','e','l','l','o',' ','w','o','r','l','d'}; StdLogosResult result = impl->send("/test/1/delivery/proto", payload); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT_EQ(result.value.get(), std::string("req-id-abc123")); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_send")); delete impl; } LOGOS_TEST(send_calls_ffi_with_byte_array_payload) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_send").returns("req-id-xyz"); std::vector payload{'t','e','s','t','-','p','a','y','l','o','a','d'}; StdLogosResult result = impl->send("/test/1/delivery/proto", payload); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT_EQ(t.cFunctionCallCount("logosdelivery_send"), 1); delete impl; } LOGOS_TEST(send_returns_error_on_ffi_failure) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); DeliveryModuleImpl implNoCtx; std::vector payload{'p','a','y','l','o','a','d'}; StdLogosResult failResult = implNoCtx.send("/topic", payload); LOGOS_ASSERT_FALSE(failResult.success); LOGOS_ASSERT_FALSE(failResult.error.empty()); delete impl; } // subscribe LOGOS_TEST(subscribe_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.subscribe("/test/1/delivery/proto").success); } LOGOS_TEST(subscribe_succeeds_with_context) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); LOGOS_ASSERT_TRUE(impl->subscribe("/test/1/delivery/proto").success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_subscribe")); delete impl; } // unsubscribe LOGOS_TEST(unsubscribe_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.unsubscribe("/test/1/delivery/proto").success); } LOGOS_TEST(unsubscribe_succeeds_with_context) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); LOGOS_ASSERT_TRUE(impl->unsubscribe("/test/1/delivery/proto").success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_unsubscribe")); delete impl; } // storeQuery LOGOS_TEST(storeQuery_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; StdLogosResult result = impl.storeQuery( R"({"requestId":"req-1","includeData":true,"paginationForward":true})", "/ip4/127.0.0.1/tcp/60000/p2p/16Uiu2peer", 5000); LOGOS_ASSERT_FALSE(result.success); LOGOS_ASSERT_FALSE(result.error.empty()); } LOGOS_TEST(storeQuery_returns_response_json) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); const char* responseJson = R"({"requestId":"req-1","statusCode":200,"statusDesc":"OK","messages":[]})"; t.mockCFunction("waku_store_query").returns(responseJson); StdLogosResult result = impl->storeQuery( R"({"requestId":"req-1","includeData":true,"paginationForward":true})", "/ip4/127.0.0.1/tcp/60000/p2p/16Uiu2peer", 5000); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT_EQ(result.value.get(), std::string(responseJson)); LOGOS_ASSERT_EQ(t.cFunctionCallCount("waku_store_query"), 1); delete impl; } // channelCreate LOGOS_TEST(channelCreate_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.channelCreate("chan-1", "/test/1/delivery/proto", "sender-1").success); LOGOS_ASSERT_FALSE(t.cFunctionCalled("logosdelivery_channel_create")); } LOGOS_TEST(channelCreate_returns_channel_id) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_channel_create").returns("chan-1"); StdLogosResult result = impl->channelCreate("chan-1", "/test/1/delivery/proto", "sender-1"); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT_EQ(result.value.get(), std::string("chan-1")); LOGOS_ASSERT_EQ(t.cFunctionCallCount("logosdelivery_channel_create"), 1); delete impl; } // channelExists LOGOS_TEST(channelExists_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.channelExists("chan-1").success); } LOGOS_TEST(channelExists_passes_through_true_and_false) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); // The FFI returns "true"/"false" verbatim; an unknown id is not an error. t.mockCFunction("logosdelivery_channel_exists").returns("true"); StdLogosResult existing = impl->channelExists("chan-1"); LOGOS_ASSERT_TRUE(existing.success); LOGOS_ASSERT_EQ(existing.value.get(), std::string("true")); t.mockCFunction("logosdelivery_channel_exists").returns("false"); StdLogosResult missing = impl->channelExists("no-such-chan"); LOGOS_ASSERT_TRUE(missing.success); LOGOS_ASSERT_EQ(missing.value.get(), std::string("false")); LOGOS_ASSERT_EQ(t.cFunctionCallCount("logosdelivery_channel_exists"), 2); delete impl; } // channelSend LOGOS_TEST(channelSend_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; std::vector payload{'h','e','l','l','o'}; LOGOS_ASSERT_FALSE(impl.channelSend("chan-1", payload).success); } LOGOS_TEST(channelSend_succeeds_and_returns_request_id) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_channel_send").returns("req-id-chan-42"); std::vector payload{'h','e','l','l','o',' ','c','h','a','n'}; StdLogosResult result = impl->channelSend("chan-1", payload); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT_EQ(result.value.get(), std::string("req-id-chan-42")); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_channel_send")); delete impl; } // channelClose LOGOS_TEST(channelClose_fails_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_FALSE(impl.channelClose("chan-1").success); } LOGOS_TEST(channelClose_succeeds_with_context) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); LOGOS_ASSERT_TRUE(impl->channelClose("chan-1").success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_channel_close")); delete impl; } // getAvailableNodeInfoIDs LOGOS_TEST(getAvailableNodeInfoIDs_returns_mocked_string) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_get_available_node_info_ids").returns("@[Version,PeerID]"); StdLogosResult result = impl->getAvailableNodeInfoIDs(); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_get_available_node_info_ids")); LOGOS_ASSERT_EQ(result.value.get(), std::string("@[Version,PeerID]")); delete impl; } LOGOS_TEST(getAvailableNodeInfoIDs_returns_empty_on_ffi_failure) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; StdLogosResult result = impl.getAvailableNodeInfoIDs(); LOGOS_ASSERT_FALSE(result.success); } // getNodeInfo LOGOS_TEST(getNodeInfo_returns_mocked_value_for_attribute) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_get_node_info").returns("v1.2.3"); StdLogosResult result = impl->getNodeInfo("Version"); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT_EQ(result.value.get(), std::string("v1.2.3")); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_get_node_info")); delete impl; } // getAvailableConfigs LOGOS_TEST(getAvailableConfigs_returns_mocked_json) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); t.mockCFunction("logosdelivery_get_available_configs").returns(R"([{"key":"mode","type":"string"}])"); StdLogosResult result = impl->getAvailableConfigs(); LOGOS_ASSERT_TRUE(result.success); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_get_available_configs")); delete impl; } LOGOS_TEST(getAvailableConfigs_returns_empty_on_ffi_failure) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; StdLogosResult result = impl.getAvailableConfigs(); LOGOS_ASSERT_FALSE(result.success); } // collectOpenMetricsText LOGOS_TEST(collectOpenMetricsText_returns_empty_without_createNode) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_EQ(impl.collectOpenMetricsText(), std::string("")); // No context -> we must not even attempt the FFI read. LOGOS_ASSERT_FALSE(t.cFunctionCalled("logosdelivery_get_node_info")); } LOGOS_TEST(collectOpenMetricsText_returns_metrics_text_verbatim) { auto t = LogosTestContext("delivery_module"); auto* impl = createInitializedImpl(t); const char* promText = "# HELP waku_node_messages_total number of messages\n" "# TYPE waku_node_messages_total counter\n" "waku_node_messages_total{shard=\"0\"} 42\n"; t.mockCFunction("logosdelivery_get_node_info").returns(promText); // The module is a pure passthrough: the openmetrics scraper does the parsing. LOGOS_ASSERT_EQ(impl->collectOpenMetricsText(), std::string(promText)); LOGOS_ASSERT(t.cFunctionCalled("logosdelivery_get_node_info")); delete impl; } // module name LOGOS_TEST(name_returns_delivery_module) { auto t = LogosTestContext("delivery_module"); DeliveryModuleImpl impl; LOGOS_ASSERT_EQ(impl.name(), std::string("delivery_module")); }