mirror of
https://github.com/logos-co/logos-liblogos.git
synced 2026-08-27 12:51:10 +00:00
Iuri Matias
f36485ba86
* extract subprocess container and container abstraction * decouple receiving token on a module loader from the container * move shim subprocess_manager to tests/ * add notes about potentially moving container registration and module_loader registration to the frontends * extract module loader abstraction and qt module loader * remove module_name_validation.h; overkill for just one function
44 lines
2.2 KiB
C++
44 lines
2.2 KiB
C++
// =============================================================================
|
|
// Unit tests for logos::isValidModuleName — the allowlist that guards an
|
|
// untrusted module name before it is used as a path segment or identifier.
|
|
//
|
|
// A module's name comes verbatim from untrusted plugin metadata. It is used as
|
|
// the registry map key, the LogosAPI RPC target, and the instance-persistence
|
|
// directory segment (basePath + "/" + name + "/" + instanceId). A name
|
|
// containing '/' or ".." would escape the intended directory or collide with
|
|
// another module, so ModuleRegistry::processModuleInternal rejects any name
|
|
// that is not a safe identifier at the trust boundary.
|
|
// =============================================================================
|
|
#include <gtest/gtest.h>
|
|
#include "module_registry.h"
|
|
|
|
#include <string>
|
|
|
|
TEST(ModuleNameValidation, AcceptsRealModuleNames) {
|
|
// Names that ship today in the workspace's metadata.json files.
|
|
EXPECT_TRUE(::logos::isValidModuleName("chat"));
|
|
EXPECT_TRUE(::logos::isValidModuleName("chat_module"));
|
|
EXPECT_TRUE(::logos::isValidModuleName("waku_module"));
|
|
EXPECT_TRUE(::logos::isValidModuleName("accounts_ui"));
|
|
EXPECT_TRUE(::logos::isValidModuleName("package-downloader"));
|
|
EXPECT_TRUE(::logos::isValidModuleName("Counter123"));
|
|
}
|
|
|
|
TEST(ModuleNameValidation, RejectsPathSeparatorsAndTraversal) {
|
|
EXPECT_FALSE(::logos::isValidModuleName("../evil"));
|
|
EXPECT_FALSE(::logos::isValidModuleName("../../etc/passwd"));
|
|
EXPECT_FALSE(::logos::isValidModuleName("a/b"));
|
|
EXPECT_FALSE(::logos::isValidModuleName("foo\\bar"));
|
|
EXPECT_FALSE(::logos::isValidModuleName(".."));
|
|
EXPECT_FALSE(::logos::isValidModuleName("."));
|
|
}
|
|
|
|
TEST(ModuleNameValidation, RejectsEmptyControlAndOverlong) {
|
|
EXPECT_FALSE(::logos::isValidModuleName(""));
|
|
EXPECT_FALSE(::logos::isValidModuleName(std::string("evil\0hidden", 10))); // embedded NUL
|
|
EXPECT_FALSE(::logos::isValidModuleName("has space"));
|
|
EXPECT_FALSE(::logos::isValidModuleName("dot.name")); // '.' is not in the allowlist
|
|
EXPECT_FALSE(::logos::isValidModuleName(std::string(65, 'a'))); // > 64 bytes
|
|
EXPECT_TRUE(::logos::isValidModuleName(std::string(64, 'a'))); // boundary: 64 ok
|
|
}
|