logos-liblogos/tests/test_module_loader_registry.cpp

// =============================================================================
// Tests for ModuleLoaderRegistry: registration, selection, fan-out operations.
//
// These tests run entirely in-process with FakeModuleLoader stubs — no Qt event
// loop, no subprocess, no file I/O.
// =============================================================================
#include <gtest/gtest.h>
#include "module_loader_registry.h"
#include <string>
#include <unordered_map>
#include <vector>

using namespace LogosCore;

// ---------------------------------------------------------------------------
// A minimal in-process stub loader used by every test below.
// Anonymous namespace prevents ODR conflicts with other FakeModuleLoader definitions
// in the same binary (e.g. test_module_loader_abstraction.cpp).
// ---------------------------------------------------------------------------
namespace {

struct FakeModuleLoader : public ModuleLoader {
    explicit FakeModuleLoader(std::string myId, std::string handledFormat = "")
        : m_id(std::move(myId)), m_handledFormat(std::move(handledFormat)) {}

    std::string id() const override { return m_id; }

    bool canHandle(const ModuleDescriptor& desc) const override {
        if (m_handledFormat.empty()) return true; // accepts anything
        return desc.format == m_handledFormat;
    }

    bool load(const ModuleDescriptor& desc,
              std::function<void(const std::string&)>,
              LoadedModuleHandle& out) override {
        out.name = desc.name;
        out.pid  = 42;
        loadCalls.push_back(desc.name);
        return loadShouldSucceed;
    }

    bool sendToken(const std::string& name, const std::string& token) override {
        sendTokenCalls.push_back({name, token});
        return true;
    }

    void terminate(const std::string& name) override {
        terminateCalls.push_back(name);
    }

    void terminateAll() override { terminateAllCount++; }

    bool hasModule(const std::string& name) const override {
        (void)name; return false;
    }

    std::unordered_map<std::string, int64_t> getAllPids() const override {
        return fakePids;
    }

    // Controllable behaviour
    bool loadShouldSucceed = true;

    // Call records
    std::vector<std::string>                             loadCalls;
    std::vector<std::pair<std::string, std::string>>     sendTokenCalls;
    std::vector<std::string>                             terminateCalls;
    int                                                  terminateAllCount = 0;

    // Configurable pids for getAllPids()
    std::unordered_map<std::string, int64_t>             fakePids;

private:
    std::string m_id;
    std::string m_handledFormat;
};

} // anonymous namespace

// =============================================================================
// Empty registry
// =============================================================================

TEST(ModuleLoaderRegistryTest, SelectReturnsNullWhenEmpty) {
    ModuleLoaderRegistry reg;
    ModuleDescriptor desc;
    desc.name   = "foo";
    desc.format = "qt-plugin";
    EXPECT_EQ(reg.select(desc), nullptr);
}

TEST(ModuleLoaderRegistryTest, TerminateAllOnEmptyRegistryDoesNotCrash) {
    ModuleLoaderRegistry reg;
    EXPECT_NO_THROW(reg.terminateAll());
}

TEST(ModuleLoaderRegistryTest, GetAllPidsOnEmptyRegistryReturnsEmptyMap) {
    ModuleLoaderRegistry reg;
    EXPECT_TRUE(reg.getAllPids().empty());
}

// =============================================================================
// canHandle dispatch
// =============================================================================

TEST(ModuleLoaderRegistryTest, SelectPicksFirstCanHandleLoader) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a", "qt-plugin");
    auto rtB = std::make_shared<FakeModuleLoader>("b", "qt-plugin");
    reg.registerLoader(rtA);
    reg.registerLoader(rtB);

    ModuleDescriptor desc;
    desc.format = "qt-plugin";
    auto selected = reg.select(desc);
    ASSERT_NE(selected, nullptr);
    EXPECT_EQ(selected->id(), "a");
}

TEST(ModuleLoaderRegistryTest, SelectSkipsLoaderThatCannotHandle) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a", "wasm");
    auto rtB = std::make_shared<FakeModuleLoader>("b", "qt-plugin");
    reg.registerLoader(rtA);
    reg.registerLoader(rtB);

    ModuleDescriptor desc;
    desc.format = "qt-plugin";
    auto selected = reg.select(desc);
    ASSERT_NE(selected, nullptr);
    EXPECT_EQ(selected->id(), "b");
}

TEST(ModuleLoaderRegistryTest, SelectReturnsNullIfNoLoaderHandlesFormat) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a", "wasm");
    reg.registerLoader(rtA);

    ModuleDescriptor desc;
    desc.format = "qt-plugin";
    EXPECT_EQ(reg.select(desc), nullptr);
}

// =============================================================================
// Explicit loaderConfig["id"] override
// =============================================================================

TEST(ModuleLoaderRegistryTest, SelectUsesExplicitIdOverride) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a", "qt-plugin");
    auto rtB = std::make_shared<FakeModuleLoader>("b", "qt-plugin");
    reg.registerLoader(rtA);
    reg.registerLoader(rtB);

    ModuleDescriptor desc;
    desc.format = "qt-plugin";
    desc.loaderConfig["id"] = "b"; // explicitly request the second one

    auto selected = reg.select(desc);
    ASSERT_NE(selected, nullptr);
    EXPECT_EQ(selected->id(), "b");
}

TEST(ModuleLoaderRegistryTest, SelectReturnsNullForUnknownExplicitId) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a", "qt-plugin");
    reg.registerLoader(rtA);

    ModuleDescriptor desc;
    desc.loaderConfig["id"] = "nonexistent-id";
    EXPECT_EQ(reg.select(desc), nullptr);
}

TEST(ModuleLoaderRegistryTest, ExplicitIdDoesNotFallThroughToCanHandle) {
    // Even if "other" is the only loader that canHandle, requesting "missing"
    // explicitly must return nullptr rather than silently routing to "other".
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("other"); // accepts anything
    reg.registerLoader(rtA);

    ModuleDescriptor desc;
    desc.loaderConfig["id"] = "missing";
    EXPECT_EQ(reg.select(desc), nullptr);
}

// =============================================================================
// terminateAll fan-out
// =============================================================================

TEST(ModuleLoaderRegistryTest, TerminateAllCallsEveryLoader) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a");
    auto rtB = std::make_shared<FakeModuleLoader>("b");
    reg.registerLoader(rtA);
    reg.registerLoader(rtB);

    reg.terminateAll();

    EXPECT_EQ(rtA->terminateAllCount, 1);
    EXPECT_EQ(rtB->terminateAllCount, 1);
}

// =============================================================================
// getAllPids aggregation
// =============================================================================

TEST(ModuleLoaderRegistryTest, GetAllPidsAggregatesAcrossLoaders) {
    ModuleLoaderRegistry reg;
    auto rtA = std::make_shared<FakeModuleLoader>("a");
    auto rtB = std::make_shared<FakeModuleLoader>("b");
    rtA->fakePids["mod1"] = 100;
    rtA->fakePids["mod2"] = 200;
    rtB->fakePids["mod3"] = 300;
    reg.registerLoader(rtA);
    reg.registerLoader(rtB);

    auto pids = reg.getAllPids();
    EXPECT_EQ(pids.size(), 3u);
    EXPECT_EQ(pids.at("mod1"), 100);
    EXPECT_EQ(pids.at("mod2"), 200);
    EXPECT_EQ(pids.at("mod3"), 300);
}

// =============================================================================
// clearForTests
// =============================================================================

TEST(ModuleLoaderRegistryTest, ClearForTests_RemovesAllLoaders) {
    ModuleLoaderRegistry reg;
    reg.registerLoader(std::make_shared<FakeModuleLoader>("a"));
    reg.registerLoader(std::make_shared<FakeModuleLoader>("b"));

    reg.clearForTests();

    ModuleDescriptor desc;
    EXPECT_EQ(reg.select(desc), nullptr);
    EXPECT_NO_THROW(reg.terminateAll());
}