mirror of
https://github.com/logos-co/logos-basecamp.git
synced 2026-08-27 06:41:14 +00:00
Dario Gabriel LipicarandClaude Opus 5
819a586cab
Sweep of documentation and comments the shell split and the pin retirement
made false. No behaviour change except one dead nix binding, below.
flake.nix
* Deletes `appImage = import ./nix/appimage.nix {...}`. That file is NOT in
the tree; the binding survived only because nix is lazy and nothing ever
forced it. Anyone referencing `appImage` would have hit a file-not-found at
eval. The shipped AppImage is the `bin-appimage` output, built by
nix-bundle-appimage.
* Four stale `Rev-pinned:` comment blocks -- logos-module-loader-qt,
logos-liblogos, logos-capability-module, logos-package-manager-ui. None of
those inputs carries a rev or ref any more; 3c21c1f retired the pins and
left every explanation behind. The logos-package-manager-ui one was a
DUPLICATED pair of near-identical paragraphs describing two different revs
of the same dead pin.
Rewritten rather than deleted, because two carried constraints that outlive
the pin and would be expensive to rediscover: capability_module fails CLOSED
without `token_registry` / `token_delivery`, and package-manager-ui is
loaded IN-PROCESS so it must match the host runtime's generation.
nix/coverage.nix
* --filter now lists BOTH app/ and src/. The split moved AppsFilterProxy,
ModulesFilterProxy, InstallEnums, ShortcutBridge and WorkspaceArea into
src/, and all five are still compiled into unit-test binaries via srcdeps --
so their .gcno/.gcda were produced and then discarded, and four of the ten
test binaries contributed nothing to the published numbers. failUnderLine
defaults to 0, so this cannot break the build.
* Its scope note still listed MainContainer as an app/ source.
app/CMakeLists.txt
* The logos_core-last rule is load-bearing on the mingw link and its comment
justified it by LogosSharedFromDll.cmake emptying the static archives --
a file deleted in #348, and contradicted by the comment 14 lines below.
The rule stands; only its stated reason was gone, which is precisely how
someone deletes it and gets four undefined references.
docs/project.md
* The app/ tree listed LogosQmlBridge.h/cpp, mdiview.h/cpp, mdichild.h/cpp
and an app/qml/ subtree of nine QML files. None exists; the QML lives at
src/Basecamp/. Replaced with the sources actually there.
* The nix/ listing named appimage.nix, macos-bundle.nix and macos-dmg.nix --
none of which exists -- and omitted symbol-gate.nix, which :193 relies on
as the thing enforcing the shell boundary.
* MainContainer's section still said app/; 9b8cf6e recorded R100 into src/.
It also said MainContainer creates MainUIBackend, which Window now owns.
* LogosQmlBridge's section cited app/ paths for an EXTERNAL header that
arrives from a flake input.
* MdiView / MdiChild sections describe classes that no longer exist; the role
is src/WorkspaceArea.
* Advertised a `.#bin-macos-dmg` output that is not defined anywhere.
tests/shutdown-tests.mjs
* Pointed at app/main.cpp:224-254 as "the orderly teardown". Those lines are
startup. The reference was already wrong when written and has since moved
twice, so it now names the block instead of line-numbering it.
doctests/basecamp-modules-bundle.test.yaml
* "Basecamp's *own* shell is deliberately NOT here: it is carried as a
main_ui plugin again" -- a fold-era clause left in front of its own
replacement, negating the rest of the sentence and the assertion below it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>