logos-co/logos-app
1
0
Fork 0
mirror of https://github.com/logos-co/logos-app.git synced 2026-08-31 03:11:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

switch to new liblogos function names (#173)

Browse Source 
* switch to new liblogos function names

* pr comments
This commit is contained in:
Dario Lipicar
2026-04-24 11:00:06 -03:00
committed by GitHub
parent ec23034cd6
commit 20a3ce3beb
13 changed files with 136 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/CoreModuleManager.cpp
+25 -22
View File
@@ -15,22 +15,25 @@
// typed wrappers above.
extern "C" {
char* logos_core_get_module_stats();
char** logos_core_get_known_plugins();
char** logos_core_get_loaded_plugins();
int logos_core_load_plugin_with_dependencies(const char* plugin_name);
int logos_core_unload_plugin(const char* plugin_name);
// Cascade unload: tears down `plugin_name` and all currently-loaded
// plugins that depend on it, in leaves-first order. Returns 1 on full
char** logos_core_get_known_modules();
char** logos_core_get_loaded_modules();
int logos_core_load_module_with_dependencies(const char* module_name);
int logos_core_unload_module(const char* module_name);
// Cascade unload: tears down `module_name` and all currently-loaded
// modules that depend on it, in leaves-first order. Returns 1 on full
// success, 0 on any failure. Remote mode only — a no-op in Local mode
// today (Basecamp gates the UI off there).
int logos_core_unload_plugin_with_dependents(const char* plugin_name);
void logos_core_refresh_plugins();
int logos_core_unload_module_with_dependents(const char* module_name);
void logos_core_refresh_modules();
}
namespace {
// Drain a NULL-terminated char** handed back by the lib and free every entry
// plus the outer array. Used by the knownPlugins / loadedPlugins wrappers.
// Drain a NULL-terminated char** handed back by the lib and release every
// entry plus the outer array. liblogos allocates these with new char[] /
// new char*[] (see module_manager.cpp::toNullTerminatedArray), so delete[]
// is the correct deallocator — do NOT use free(). Used by the knownModules
// / loadedModules wrappers.
QStringList drainCStringArray(char** arr)
{
QStringList out;
@@ -63,29 +66,29 @@ CoreModuleManager::~CoreModuleManager()
if (m_statsTimer) m_statsTimer->stop();
}
QStringList CoreModuleManager::knownPlugins() const
QStringList CoreModuleManager::knownModules() const
{
return drainCStringArray(logos_core_get_known_plugins());
return drainCStringArray(logos_core_get_known_modules());
}
QStringList CoreModuleManager::loadedPlugins() const
QStringList CoreModuleManager::loadedModules() const
{
return drainCStringArray(logos_core_get_loaded_plugins());
return drainCStringArray(logos_core_get_loaded_modules());
}
bool CoreModuleManager::loadPlugin(const QString& name)
bool CoreModuleManager::loadModule(const QString& name)
{
return logos_core_load_plugin_with_dependencies(name.toUtf8().constData()) == 1;
return logos_core_load_module_with_dependencies(name.toUtf8().constData()) == 1;
}
bool CoreModuleManager::unloadPlugin(const QString& name)
bool CoreModuleManager::unloadModule(const QString& name)
{
return logos_core_unload_plugin(name.toUtf8().constData()) == 1;
return logos_core_unload_module(name.toUtf8().constData()) == 1;
}
bool CoreModuleManager::unloadPluginWithDependents(const QString& name)
bool CoreModuleManager::unloadModuleWithDependents(const QString& name)
{
return logos_core_unload_plugin_with_dependents(name.toUtf8().constData()) == 1;
return logos_core_unload_module_with_dependents(name.toUtf8().constData()) == 1;
}
QVariantMap CoreModuleManager::moduleStats(const QString& name) const
@@ -95,9 +98,9 @@ QVariantMap CoreModuleManager::moduleStats(const QString& name) const
void CoreModuleManager::refresh()
{
// Re-scan all plugin directories via the lib, then let the Modules tab
// Re-scan all module directories via the lib, then let the Modules tab
// re-read the composed list through Q_PROPERTY.
logos_core_refresh_plugins();
logos_core_refresh_modules();
emit coreModulesChanged();
}