From fcb90f6f11892a04514e9bd81c1f3f407d7ada1f Mon Sep 17 00:00:00 2001
From: Sergio Chouhy <sergio.chouhy@gmail.com>
Date: Sat, 9 Aug 2025 18:37:04 -0300
Subject: [PATCH] clippy

---
 nssa/src/lib.rs                |  2 +-
 nssa/src/public_transaction.rs |  4 ++--
 nssa/src/signature.rs          |  2 +-
 nssa/src/state.rs              | 14 +++++++-------
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/nssa/src/lib.rs b/nssa/src/lib.rs
index 455afa2..7010a88 100644
--- a/nssa/src/lib.rs
+++ b/nssa/src/lib.rs
@@ -1,6 +1,6 @@
 use nssa_core::{
     account::{Account, AccountWithMetadata},
-    program::{DEFAULT_PROGRAM_ID, ProgramId},
+    program::DEFAULT_PROGRAM_ID,
 };
 use program_methods::{AUTHENTICATED_TRANSFER_ELF, AUTHENTICATED_TRANSFER_ID};
 use risc0_zkvm::{ExecutorEnv, ExecutorEnvBuilder, default_executor};
diff --git a/nssa/src/public_transaction.rs b/nssa/src/public_transaction.rs
index 828e906..756cbdd 100644
--- a/nssa/src/public_transaction.rs
+++ b/nssa/src/public_transaction.rs
@@ -1,5 +1,5 @@
 use nssa_core::{
-    account::{Account, Nonce},
+    account::Nonce,
     program::ProgramId,
 };
 use serde::{Deserialize, Serialize};
@@ -92,6 +92,6 @@ impl PublicTransaction {
         let bytes = serde_cbor::to_vec(&self).unwrap();
         let mut hasher = sha2::Sha256::new();
         hasher.update(&bytes);
-        hasher.finalize_fixed().try_into().unwrap()
+        hasher.finalize_fixed().into()
     }
 }
diff --git a/nssa/src/signature.rs b/nssa/src/signature.rs
index be8b937..4c0ebb7 100644
--- a/nssa/src/signature.rs
+++ b/nssa/src/signature.rs
@@ -1,6 +1,6 @@
 use serde::{Deserialize, Serialize};
 
-use crate::{address::Address, public_transaction::Message};
+use crate::public_transaction::Message;
 
 #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
 pub(crate) struct Signature;
diff --git a/nssa/src/state.rs b/nssa/src/state.rs
index 986073c..b4d697a 100644
--- a/nssa/src/state.rs
+++ b/nssa/src/state.rs
@@ -40,7 +40,7 @@ impl V01State {
 
     pub fn transition_from_public_transaction(&mut self, tx: &PublicTransaction) -> Result<(), ()> {
         let state_diff = self
-            .execute_and_verify_public_transaction(&tx)
+            .execute_and_verify_public_transaction(tx)
             .map_err(|_| ())?;
 
         for (address, post) in state_diff.into_iter() {
@@ -58,7 +58,7 @@ impl V01State {
     fn get_account_by_address_mut(&mut self, address: Address) -> &mut Account {
         self.public_state
             .entry(address)
-            .or_insert_with(Account::default)
+            .or_default()
     }
 
     pub fn get_account_by_address(&self, address: &Address) -> Account {
@@ -137,7 +137,7 @@ impl V01State {
             .addresses
             .iter()
             .cloned()
-            .zip(post_states.into_iter())
+            .zip(post_states)
             .collect())
     }
 }
@@ -166,7 +166,7 @@ mod tests {
     fn test_1() {
         let initial_data = [([1; 32], 100)];
         let mut state = V01State::new_with_genesis_accounts(&initial_data);
-        let from = Address::new(initial_data[0].0.clone());
+        let from = Address::new(initial_data[0].0);
         let from_key = PrivateKey(1);
         let to = Address::new([2; 32]);
         let balance_to_move = 5;
@@ -184,9 +184,9 @@ mod tests {
     fn test_2() {
         let initial_data = [([1; 32], 100), ([99; 32], 200)];
         let mut state = V01State::new_with_genesis_accounts(&initial_data);
-        let from = Address::new(initial_data[1].0.clone());
+        let from = Address::new(initial_data[1].0);
         let from_key = PrivateKey(99);
-        let to = Address::new(initial_data[0].0.clone());
+        let to = Address::new(initial_data[0].0);
         let balance_to_move = 8;
         let to_previous_balance = state.get_account_by_address(&to).balance;
         let tx =
@@ -203,7 +203,7 @@ mod tests {
     fn test_3() {
         let initial_data = [([1; 32], 100)];
         let mut state = V01State::new_with_genesis_accounts(&initial_data);
-        let address_1 = Address::new(initial_data[0].0.clone());
+        let address_1 = Address::new(initial_data[0].0);
         let key_1 = PrivateKey(1);
         let address_2 = Address::new([2; 32]);