logos-blockchain/lssa
1
0
Fork 0
mirror of https://github.com/logos-blockchain/lssa.git synced 2026-04-12 06:03:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow passthrough signer accounts in rule 7 validation

Browse Source 
Previously rule 7 rejected any non-default account with DEFAULT_PROGRAM_ID
owner in post_states, even if the account was completely unchanged.

This made it impossible for programs to verify external signers via
is_authorized when the signer had prior transactions (nonce > 0).

Fix: skip rule 7 if pre.account == post.account (passthrough).
This enables multisig/governance programs to include signer accounts
as read-only inputs without modifying them.

Added regression test: passthrough_signer_account_allowed_in_rule_7

Fixes #339
This commit is contained in:
ygd58 2026-03-27 22:36:52 +01:00
parent fb083ce91e
commit eed9cc6296
No known key found for this signature in database
GPG Key ID: 82B49AE8D5B28600
1 changed files with 54 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
nssa/core/src/program.rs
View File

@ -300,8 +300,14 @@ pub fn validate_execution(
}
// 7. If a post state has default program owner, the pre state must have been a default
// account
if post.account.program_owner == DEFAULT_PROGRAM_ID && pre.account != Account::default() {
// account. Exception: if the account is completely unchanged (passthrough signer),
// allow it — this enables programs to verify external signers via is_authorized
// without claiming or modifying the signer's account.
// See: https://github.com/logos-blockchain/logos-execution-zone/issues/339
if post.account.program_owner == DEFAULT_PROGRAM_ID
&& pre.account != Account::default()
&& pre.account != post.account
{
return false;
}
}
@ -372,6 +378,52 @@ mod tests {
assert!(!account_post_state.requires_claim());
}
#[test]
fn passthrough_signer_account_allowed_in_rule_7() {
// Regression test for https://github.com/logos-blockchain/logos-execution-zone/issues/339
// Programs should be able to include external signer accounts (nonce > 0) in pre/post
// states unchanged, enabling is_authorized checks for multisig/governance programs.
use crate::account::{Account, AccountId, AccountWithMetadata, Data};
let signer_account = Account {
program_owner: DEFAULT_PROGRAM_ID,
balance: 0,
data: Data::default(),
nonce: 1u128.into(), // nonce > 0: previously used account
};
let program_id = [1u32; 8];
let account_id: AccountId = "11111111111111111111111111111111".parse().unwrap();
let pre = AccountWithMetadata {
account: signer_account.clone(),
is_authorized: true,
account_id: account_id.clone(),
};
let post = AccountPostState::new(signer_account.clone()); // unchanged
// Should pass: account is completely unchanged (passthrough signer)
let result = validate_execution(
&[pre.clone()],
&[post],
program_id,
);
assert!(result, "passthrough signer account should be allowed");
// Should fail: account is modified while still having DEFAULT_PROGRAM_ID owner
let mut modified_account = signer_account.clone();
modified_account.balance = 100;
let post_modified = AccountPostState::new(modified_account);
let result_modified = validate_execution(
&[pre],
&[post_modified],
program_id,
);
assert!(!result_modified, "modified default-owner account should be rejected");
}
#[test]
fn post_state_account_getter() {
let mut account = Account {