From ed6349e724f19d4637583ae322d59dcb7d321024 Mon Sep 17 00:00:00 2001 From: Artem Gureev Date: Thu, 16 Jul 2026 14:51:41 +0000 Subject: [PATCH] refactor(verifier): consume bundled public_actions directly --- .../src/privacy_preserving_transaction/message.rs | 8 -------- lee/state_machine/src/validated_state_diff/mod.rs | 13 ++++++++----- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/lee/state_machine/src/privacy_preserving_transaction/message.rs b/lee/state_machine/src/privacy_preserving_transaction/message.rs index 715920fa..22c29a5d 100644 --- a/lee/state_machine/src/privacy_preserving_transaction/message.rs +++ b/lee/state_machine/src/privacy_preserving_transaction/message.rs @@ -100,14 +100,6 @@ impl Message { .collect() } - #[must_use] - pub fn public_post_states(&self) -> Vec { - self.public_actions - .iter() - .map(|action| action.post_state.clone()) - .collect() - } - #[must_use] pub fn hash(&self) -> [u8; 32] { let msg = self.to_bytes(); diff --git a/lee/state_machine/src/validated_state_diff/mod.rs b/lee/state_machine/src/validated_state_diff/mod.rs index 755d2f12..4d28bebe 100644 --- a/lee/state_machine/src/validated_state_diff/mod.rs +++ b/lee/state_machine/src/validated_state_diff/mod.rs @@ -397,10 +397,10 @@ impl ValidatedStateDiff { // 6. Nullifier uniqueness state.check_nullifiers_are_valid(&nullifiers)?; - let public_diff = public_account_ids + let public_diff = message + .public_actions .iter() - .copied() - .zip(message.public_post_states()) + .map(|action| (action.account_id, action.post_state.clone())) .collect(); let new_nullifiers = nullifiers.iter().map(|(nullifier, _)| *nullifier).collect(); @@ -491,8 +491,11 @@ fn check_privacy_preserving_circuit_proof_is_valid( public_actions: public_pre_states .iter() .cloned() - .zip(message.public_post_states()) - .map(|(pre, post)| PublicAction { pre, post }) + .zip(&message.public_actions) + .map(|(pre, action)| PublicAction { + pre, + post: action.post_state.clone(), + }) .collect(), private_actions: message.private_actions.clone(), block_validity_window: message.block_validity_window,