logos-blockchain/lssa
1
0
Fork 0
mirror of https://github.com/logos-blockchain/lssa.git synced 2026-01-06 23:33:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

return parse error for invalid addresses

Browse Source
This commit is contained in:
Sergio Chouhy 2025-07-22 09:13:41 -03:00
parent d1cd653ed5
commit cab71a0e00
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
sequencer_rpc/src/process.rs
View File

@ -2,7 +2,7 @@ use actix_web::Error as HttpError;
use serde_json::Value; use serde_json::Value;
use common::rpc_primitives::{ use common::rpc_primitives::{
errors::RpcError, errors::{RpcError, RpcParseError},
message::{Message, Request}, message::{Message, Request},
parser::RpcRequest, parser::RpcRequest,
requests::{GetAccountBalanceRequest, GetAccountBalanceResponse}, requests::{GetAccountBalanceRequest, GetAccountBalanceResponse},
@ -137,13 +137,13 @@ impl JsonHandler {
} }
/// Returns the balance of the account at the given address. /// Returns the balance of the account at the given address.
/// The address must be a valid hex string. If it's invalid or the account doesn't exist, /// The address must be a valid hex string. If the account doesn't exist, a balance of zero is returned.
/// a balance of zero is returned.
async fn process_get_account_balance(&self, request: Request) -> Result<Value, RpcErr> { async fn process_get_account_balance(&self, request: Request) -> Result<Value, RpcErr> {
let get_account_req = GetAccountBalanceRequest::parse(Some(request.params))?; let get_account_req = GetAccountBalanceRequest::parse(Some(request.params))?;
let address = hex::decode(get_account_req.address)
.map_err(|_| RpcParseError("invalid address".to_string()))?;
let balance = { let balance = {
let address = hex::decode(get_account_req.address).unwrap_or_default();
let state = self.sequencer_state.lock().await; let state = self.sequencer_state.lock().await;
state state
.store .store
@ -248,7 +248,7 @@ mod tests {
let request = serde_json::json!({ let request = serde_json::json!({
"jsonrpc": "2.0", "jsonrpc": "2.0",
"method": "get_account_balance", "method": "get_account_balance",
"params": { "address": "cofe".repeat(16) }, "params": { "address": "efac".repeat(16) },
"id": 1 "id": 1
}); });
let expected_response = serde_json::json!({ let expected_response = serde_json::json!({
@ -274,13 +274,21 @@ mod tests {
"id": 1 "id": 1
}); });
let expected_response = serde_json::json!({ let expected_response = serde_json::json!({
"id": 1,
"jsonrpc": "2.0", "jsonrpc": "2.0",
"result": { "id": 1,
"balance": 0 "error": {
"code": -32700,
"message": "Parse error",
"name": "REQUEST_VALIDATION_ERROR",
"data": "invalid address",
"cause": {
"name": "PARSE_ERROR",
"info": {
"error_message": "invalid address"
}
}
} }
}); });
let response = call_rpc_handler_with_json(json_handler, request).await; let response = call_rpc_handler_with_json(json_handler, request).await;
assert_eq!(response, expected_response); assert_eq!(response, expected_response);