fix: final fixes & polishing

key_protocol/Cargo.toml

@@ -19,10 +19,12 @@ serde.workspace = true
 k256.workspace = true
 sha2.workspace = true
 rand.workspace = true
-base58.workspace = true
 hex.workspace = true
 aes-gcm.workspace = true
 bip39.workspace = true
 hmac-sha512.workspace = true
 thiserror.workspace = true
 itertools.workspace = true
+
+[dev-dependencies]
+base58.workspace = true

key_protocol/src/key_management/secret_holders.rs

@@ -10,16 +10,16 @@ use sha2::{Digest as _, digest::FixedOutput as _};
 
 const NSSA_ENTROPY_BYTES: [u8; 32] = [0; 32];
 
-#[derive(Debug)]
 /// Seed holder. Non-clonable to ensure that different holders use different seeds.
 /// Produces `TopSecretKeyHolder` objects.
+#[derive(Debug)]
 pub struct SeedHolder {
     // ToDo: Needs to be vec as serde derives is not implemented for [u8; 64]
     pub(crate) seed: Vec<u8>,
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq)]
 /// Secret spending key object. Can produce `PrivateKeyHolder` objects.
+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq)]
 pub struct SecretSpendingKey(pub(crate) [u8; 32]);
 
 pub type ViewingSecretKey = Scalar;

key_protocol/src/key_protocol_core/mod.rs

@@ -66,13 +66,13 @@ impl NSSAUserData {
     ) -> Result<Self> {
         if !Self::valid_public_key_transaction_pairing_check(&default_accounts_keys) {
             anyhow::bail!(
-                "Key transaction pairing check not satisfied, there is account_ids, which is not derived from keys"
+                "Key transaction pairing check not satisfied, there are public account_ids, which is not derived from keys"
             );
         }
 
         if !Self::valid_private_key_transaction_pairing_check(&default_accounts_key_chains) {
             anyhow::bail!(
-                "Key transaction pairing check not satisfied, there is account_ids, which is not derived from keys"
+                "Key transaction pairing check not satisfied, there are private account_ids, which is not derived from keys"
             );
         }