clippy

common/src/merkle_tree_public/merkle_tree.rs

@@ -8,7 +8,7 @@ use serde::{
 };
 
 use crate::{
-    transaction::{AuthenticatedTransaction, Transaction, TransactionBody},
+    transaction::Transaction,
     utxo_commitment::UTXOCommitment,
 };
 

common/src/rpc_primitives/requests.rs

@@ -1,7 +1,6 @@
 use crate::block::Block;
 use crate::parse_request;
 use crate::transaction::Transaction;
-use crate::transaction::TransactionBody;
 
 use super::errors::RpcParseError;
 use super::parser::parse_params;

common/src/transaction.rs

@@ -1,17 +1,12 @@
-use k256::{
-    ecdsa::{
+use k256::ecdsa::{
         signature::hazmat::{PrehashSigner, PrehashVerifier},
         Signature, SigningKey, VerifyingKey,
-    },
-    EncodedPoint, Scalar,
-};
+    };
 use log::info;
 use secp256k1_zkp::{PedersenCommitment, Tweak};
-use serde::de::{Error as DeError, Visitor};
-use serde::{Deserialize, Deserializer, Serialize, Serializer};
+use serde::{Deserialize, Serialize};
 
 use sha2::{digest::FixedOutput, Digest};
-use std::fmt;
 
 use crate::merkle_tree_public::TreeHashType;
 
@@ -156,7 +151,7 @@ impl ActionData {
                     .into_iter()
                     .map(|owned_utxo| owned_utxo.into())
                     .collect();
-                format!("Published utxos {:?}", pub_own_utxo)
+                format!("Published utxos {pub_own_utxo:?}")
             }
         }
     }
@@ -195,21 +190,21 @@ impl TransactionBody {
             "Transaction utxo_commitments_spent_hashes is {:?}",
             self.utxo_commitments_spent_hashes
                 .iter()
-                .map(|val| hex::encode(val.clone()))
+                .map(|val| hex::encode(*val))
                 .collect::<Vec<_>>()
         );
         info!(
             "Transaction utxo_commitments_created_hashes is {:?}",
             self.utxo_commitments_created_hashes
                 .iter()
-                .map(|val| hex::encode(val.clone()))
+                .map(|val| hex::encode(*val))
                 .collect::<Vec<_>>()
         );
         info!(
             "Transaction nullifier_created_hashes is {:?}",
             self.nullifier_created_hashes
                 .iter()
-                .map(|val| hex::encode(val.clone()))
+                .map(|val| hex::encode(*val))
                 .collect::<Vec<_>>()
         );
         info!(

storage/src/lib.rs

@@ -316,7 +316,7 @@ impl RocksDBIO {
         let cf_sc = self.sc_column();
 
         let sc_addr_loc = format!("{sc_addr:?}{SC_LEN_SUFFIX}");
-        let sc_len_addr = sc_addr_loc.as_str().as_bytes();
+        let sc_len_addr = sc_addr_loc.as_bytes();
 
         self.db
             .put_cf(&cf_sc, sc_len_addr, length.to_be_bytes())
@@ -360,7 +360,7 @@ impl RocksDBIO {
         let cf_sc = self.sc_column();
         let sc_addr_loc = format!("{sc_addr:?}{SC_LEN_SUFFIX}");
 
-        let sc_len_addr = sc_addr_loc.as_str().as_bytes();
+        let sc_len_addr = sc_addr_loc.as_bytes();
 
         let sc_len = self
             .db
@@ -379,11 +379,11 @@ impl RocksDBIO {
     ///Get full sc state from DB
     pub fn get_sc_sc_state(&self, sc_addr: &str) -> DbResult<Vec<DataBlob>> {
         let cf_sc = self.sc_column();
-        let sc_len = self.get_sc_sc_state_len(&sc_addr)?;
+        let sc_len = self.get_sc_sc_state_len(sc_addr)?;
         let mut data_blob_list = vec![];
 
         for id in 0..sc_len {
-            let blob_addr = produce_address_for_data_blob_at_id(&sc_addr, id);
+            let blob_addr = produce_address_for_data_blob_at_id(sc_addr, id);
 
             let blob = self
                 .db
@@ -541,7 +541,7 @@ impl RocksDBIO {
 
 ///Creates address for sc data blob at corresponding id
 fn produce_address_for_data_blob_at_id(sc_addr: &str, id: usize) -> Vec<u8> {
-    let mut prefix_bytes: Vec<u8> = sc_addr.as_bytes().iter().cloned().collect();
+    let mut prefix_bytes: Vec<u8> = sc_addr.as_bytes().to_vec();
 
     let id_bytes = id.to_be_bytes();
 

utxo/src/utxo_core.rs

@@ -58,7 +58,7 @@ impl UTXO {
     }
     pub fn create_utxo_from_payload(payload_with_asset: UTXOPayload) -> Self {
         let mut hasher = sha2::Sha256::new();
-        hasher.update(&payload_with_asset.to_bytes());
+        hasher.update(payload_with_asset.to_bytes());
         let hash = <TreeHashType>::from(hasher.finalize_fixed());
 
         Self {