From 801f2c46c81b2135ab1fc79ae8f56bd40b4d876d Mon Sep 17 00:00:00 2001 From: Pravdyvy <46261001+Pravdyvy@users.noreply.github.com> Date: Mon, 23 Feb 2026 10:11:40 +0200 Subject: [PATCH] Apply suggestions from code review Docstrings updated, derives sorted. Co-authored-by: Daniil Polyakov --- common/src/block.rs | 8 ++++---- common/src/transaction.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/src/block.rs b/common/src/block.rs index ea6099fb..108b0072 100644 --- a/common/src/block.rs +++ b/common/src/block.rs @@ -109,15 +109,15 @@ impl From for HashableBlockData { } } -#[derive(Debug, Serialize, Deserialize, Clone)] -/// Helperstruct for account serialization +/// Helper struct for account (de-)serialization +#[derive(Debug, Clone, Serialize, Deserialize)] pub struct AccountInitialData { pub account_id: AccountId, pub balance: u128, } -#[derive(Debug, Serialize, Deserialize, Clone)] -/// Helperstruct to initialize commitments +/// Helper struct to (de-)serialize initial commitments +#[derive(Debug, Clone, Serialize, Deserialize)] pub struct CommitmentsInitialData { pub npk: nssa_core::NullifierPublicKey, pub account: nssa_core::account::Account, diff --git a/common/src/transaction.rs b/common/src/transaction.rs index 87e31a4c..6f706815 100644 --- a/common/src/transaction.rs +++ b/common/src/transaction.rs @@ -61,7 +61,7 @@ pub enum TxKind { ProgramDeployment, } -#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] +#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] pub enum TransactionMalformationError { InvalidSignature, FailedToDecode { tx: HashType },