From 0b2650127ac4b25eecdfd453e7582bb5295dce23 Mon Sep 17 00:00:00 2001
From: Sergio Chouhy <sergio.chouhy@gmail.com>
Date: Tue, 12 Aug 2025 16:55:56 -0300
Subject: [PATCH] clippy

---
 common/src/rpc_primitives/requests.rs      | 1 -
 nssa/src/public_transaction/message.rs     | 1 -
 nssa/src/public_transaction/mod.rs         | 5 +----
 nssa/src/public_transaction/witness_set.rs | 6 ++----
 nssa/src/signature/public_key.rs           | 5 ++---
 nssa/src/signature/signature.rs            | 5 ++---
 sequencer_rpc/src/process.rs               | 1 -
 wallet/src/lib.rs                          | 1 -
 8 files changed, 7 insertions(+), 18 deletions(-)

diff --git a/common/src/rpc_primitives/requests.rs b/common/src/rpc_primitives/requests.rs
index 085051b..2e67f16 100644
--- a/common/src/rpc_primitives/requests.rs
+++ b/common/src/rpc_primitives/requests.rs
@@ -1,4 +1,3 @@
-use crate::block::Block;
 use crate::parse_request;
 
 use super::errors::RpcParseError;
diff --git a/nssa/src/public_transaction/message.rs b/nssa/src/public_transaction/message.rs
index 28322c2..e137da3 100644
--- a/nssa/src/public_transaction/message.rs
+++ b/nssa/src/public_transaction/message.rs
@@ -1,4 +1,3 @@
-use std::io::{Cursor, Read};
 
 use nssa_core::{
     account::Nonce,
diff --git a/nssa/src/public_transaction/mod.rs b/nssa/src/public_transaction/mod.rs
index 769be5a..efb53ef 100644
--- a/nssa/src/public_transaction/mod.rs
+++ b/nssa/src/public_transaction/mod.rs
@@ -1,7 +1,4 @@
-use std::{
-    collections::{HashMap, HashSet},
-    io::Cursor,
-};
+use std::collections::{HashMap, HashSet};
 
 use nssa_core::{
     account::{Account, AccountWithMetadata},
diff --git a/nssa/src/public_transaction/witness_set.rs b/nssa/src/public_transaction/witness_set.rs
index e9b0f59..8bbce86 100644
--- a/nssa/src/public_transaction/witness_set.rs
+++ b/nssa/src/public_transaction/witness_set.rs
@@ -1,8 +1,6 @@
-use std::io::{Cursor, Read};
 
-use serde::{Deserialize, Serialize};
 
-use crate::{PrivateKey, PublicKey, Signature, error::NssaError, public_transaction::Message};
+use crate::{PrivateKey, PublicKey, Signature, public_transaction::Message};
 
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct WitnessSet {
@@ -24,7 +22,7 @@ impl WitnessSet {
     pub fn is_valid_for(&self, message: &Message) -> bool {
         let message_bytes = message.to_bytes();
         for (signature, public_key) in self.iter_signatures() {
-            if !signature.is_valid_for(&message_bytes, &public_key) {
+            if !signature.is_valid_for(&message_bytes, public_key) {
                 return false;
             }
         }
diff --git a/nssa/src/signature/public_key.rs b/nssa/src/signature/public_key.rs
index bda1548..18dc830 100644
--- a/nssa/src/signature/public_key.rs
+++ b/nssa/src/signature/public_key.rs
@@ -1,6 +1,5 @@
-use std::io::{Cursor, Read};
 
-use serde::{Deserialize, Serialize};
+use serde::Serialize;
 
 use crate::PrivateKey;
 
@@ -23,7 +22,7 @@ impl PublicKey {
 
 #[cfg(test)]
 mod tests {
-    use crate::{PrivateKey, PublicKey, signature::tests::test_vectors};
+    use crate::{PublicKey, signature::tests::test_vectors};
 
     #[test]
     fn test_public_key_generation_from_bip340_test_vectors() {
diff --git a/nssa/src/signature/signature.rs b/nssa/src/signature/signature.rs
index 0bfcbd7..dcb8b7c 100644
--- a/nssa/src/signature/signature.rs
+++ b/nssa/src/signature/signature.rs
@@ -1,8 +1,7 @@
-use std::io::{Cursor, Read};
 
 use rand::{RngCore, rngs::OsRng};
 
-use crate::{PrivateKey, PublicKey, error::NssaError, public_transaction::Message};
+use crate::{PrivateKey, PublicKey};
 
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct Signature {
@@ -31,7 +30,7 @@ impl Signature {
         let pk = secp256k1::XOnlyPublicKey::from_byte_array(public_key.0).unwrap();
         let secp = secp256k1::Secp256k1::new();
         let sig = secp256k1::schnorr::Signature::from_byte_array(self.value);
-        secp.verify_schnorr(&sig, &bytes, &pk).is_ok()
+        secp.verify_schnorr(&sig, bytes, &pk).is_ok()
     }
 }
 
diff --git a/sequencer_rpc/src/process.rs b/sequencer_rpc/src/process.rs
index d308659..4d7ba83 100644
--- a/sequencer_rpc/src/process.rs
+++ b/sequencer_rpc/src/process.rs
@@ -1,4 +1,3 @@
-use std::io::Cursor;
 
 use actix_web::Error as HttpError;
 use base64::{engine::general_purpose, Engine};
diff --git a/wallet/src/lib.rs b/wallet/src/lib.rs
index b464ede..f4add81 100644
--- a/wallet/src/lib.rs
+++ b/wallet/src/lib.rs
@@ -8,7 +8,6 @@ use common::{
 use accounts::account_core::{address::AccountAddress, Account};
 use anyhow::Result;
 use chain_storage::WalletChainStore;
-use common::transaction::TransactionBody;
 use config::WalletConfig;
 use log::info;
 use tokio::sync::RwLock;