Marvin Jones 58cc795ae8 docs(lee): trim/dedup docstrings introduced in PR3, fix clippy debt ...

Trim the signer_account_ids/PublicDiff explanation down to one canonical
location per concept instead of restating it at every call site, drop
dangling "See X" pointers in favor of letting readers look up the code
directly, and shorten the two malicious-victim test docstrings that
re-derived the same mechanism already covered elsewhere.

Separately, fix pre-existing clippy debt that was hidden behind compile
errors in the two guest binaries clippy could originally reach:
- update_from_diff implementations across most lez/programs/* guests,
  test_methods_guests, test_programs/guest, and the program_deployment
  examples returned Result<Data, Infallible> for no reason; now return
  Data directly.
- unchanged(...) helpers made const fn.
- Program::execute_update_from_diff/prove_update_from_diff took Account/Data
  by value without consuming them; now take references, dropping the
  now-unnecessary clones at every call site.
- One redundant clone, one redundant closure, one large enum variant
  (TxEvaluation::Accept now boxes its LeeTransaction), and four
  if-let/else patterns simplified to map_or_else/bool::then in the
  indexer FFI's AccountDiff/Claim conversions.

Rebuild every affected guest artifact and the prebuilt test fixture.

2026-08-22 11:37:57 -04:00

396 KiB

Raw History

View Raw