feat: add pedantic clippy lints

test_program_methods/guest/src/bin/burner.rs

@@ -11,9 +11,8 @@ fn main() {
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = &pre.account;

test_program_methods/guest/src/bin/chain_caller.rs

@@ -8,7 +8,8 @@ type Instruction = (u128, ProgramId, u32, Option<PdaSeed>);
 
 /// A program that calls another program `num_chain_calls` times.
 /// It permutes the order of the input accounts on the subsequent call
-/// The `ProgramId` in the instruction must be the program_id of the authenticated transfers program
+/// The `ProgramId` in the instruction must be the `program_id` of the authenticated transfers
+/// program
 fn main() {
     let (
         ProgramInput {
@@ -18,9 +19,8 @@ fn main() {
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [recipient_pre, sender_pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([recipient_pre, sender_pre]) = <[_; 2]>::try_from(pre_states) else {
+        return;
     };
 
     let instruction_data = to_vec(&balance).unwrap();

test_program_methods/guest/src/bin/changer_claimer.rs

@@ -12,9 +12,8 @@ fn main() {
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = &pre.account;

test_program_methods/guest/src/bin/claimer.rs

@@ -6,14 +6,13 @@ fn main() {
     let (
         ProgramInput {
             pre_states,
-            instruction: _,
+            instruction: (),
         },
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_post = AccountPostState::new_claimed(pre.account.clone());

test_program_methods/guest/src/bin/data_changer.rs

@@ -12,9 +12,8 @@ fn main() {
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = &pre.account;

test_program_methods/guest/src/bin/extra_output.rs

@@ -8,9 +8,8 @@ type Instruction = ();
 fn main() {
     let (ProgramInput { pre_states, .. }, instruction_words) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = pre.account.clone();

test_program_methods/guest/src/bin/malicious_authorization_changer.rs

@@ -21,9 +21,8 @@ fn main() {
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [sender, receiver] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([sender, receiver]) = <[_; 2]>::try_from(pre_states) else {
+        return;
     };
 
     // Maliciously set is_authorized to true for the first account

test_program_methods/guest/src/bin/minter.rs

@@ -5,9 +5,8 @@ type Instruction = ();
 fn main() {
     let (ProgramInput { pre_states, .. }, instruction_words) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = &pre.account;

test_program_methods/guest/src/bin/missing_output.rs

@@ -5,9 +5,8 @@ type Instruction = ();
 fn main() {
     let (ProgramInput { pre_states, .. }, instruction_words) = read_nssa_inputs::<Instruction>();
 
-    let [pre1, pre2] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre1, pre2]) = <[_; 2]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre1 = pre1.account.clone();

test_program_methods/guest/src/bin/modified_transfer.rs

@@ -6,18 +6,17 @@ use nssa_core::{
 /// Initializes a default account under the ownership of this program.
 /// This is achieved by a noop.
 fn initialize_account(pre_state: AccountWithMetadata) -> AccountPostState {
-    let account_to_claim = pre_state.account.clone();
+    let account_to_claim = pre_state.account;
     let is_authorized = pre_state.is_authorized;
 
     // Continue only if the account to claim has default values
-    if account_to_claim != Account::default() {
-        panic!("Account is already initialized");
-    }
+    assert!(
+        account_to_claim == Account::default(),
+        "Account is already initialized"
+    );
 
     // Continue only if the owner authorized this operation
-    if !is_authorized {
-        panic!("Missing required authorization");
-    }
+    assert!(is_authorized, "Missing required authorization");
 
     AccountPostState::new(account_to_claim)
 }
@@ -29,9 +28,7 @@ fn transfer(
     balance_to_move: u128,
 ) -> Vec<AccountPostState> {
     // Continue only if the sender has authorized this operation
-    if !sender.is_authorized {
-        panic!("Missing required authorization");
-    }
+    assert!(sender.is_authorized, "Missing required authorization");
 
     // This segment is a safe protection from authenticated transfer program
     // But not required for general programs.
@@ -44,8 +41,8 @@ fn transfer(
     let malicious_offset = base.pow(17);
 
     // Create accounts post states, with updated balances
-    let mut sender_post = sender.account.clone();
-    let mut recipient_post = recipient.account.clone();
+    let mut sender_post = sender.account;
+    let mut recipient_post = recipient.account;
 
     sender_post.balance -= balance_to_move + malicious_offset;
     recipient_post.balance += balance_to_move + malicious_offset;

test_program_methods/guest/src/bin/nonce_changer.rs

@@ -5,9 +5,8 @@ type Instruction = ();
 fn main() {
     let (ProgramInput { pre_states, .. }, instruction_words) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = &pre.account;

test_program_methods/guest/src/bin/program_owner_changer.rs

@@ -5,9 +5,8 @@ type Instruction = ();
 fn main() {
     let (ProgramInput { pre_states, .. }, instruction_words) = read_nssa_inputs::<Instruction>();
 
-    let [pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([pre]) = <[_; 1]>::try_from(pre_states) else {
+        return;
     };
 
     let account_pre = &pre.account;

test_program_methods/guest/src/bin/simple_balance_transfer.rs

@@ -11,9 +11,8 @@ fn main() {
         instruction_words,
     ) = read_nssa_inputs::<Instruction>();
 
-    let [sender_pre, receiver_pre] = match pre_states.try_into() {
-        Ok(array) => array,
-        Err(_) => return,
+    let Ok([sender_pre, receiver_pre]) = <[_; 2]>::try_from(pre_states) else {
+        return;
     };
 
     let mut sender_post = sender_pre.account.clone();