refactor: rename mask3 to private_pda in tests and circuit

Browse Source

Addresses the following review comments:

- "I'd rename all mask_3 references in test names and variables to a
  private pda wording. If in the future we change the mask number for
  the private pda, this naming will silently get outdated."
  I renamed all tests and the local variable mask3_account to
  private_pda_account.

- "Let's use more descriptive names. `mask3` is not very meaningful."
  I renamed all `mask3` into `private_pda`. Panic messages and .expect
  strings updated to match. Doc comments that factually describe the
  encoding (e.g. "mask-3 account" meaning "an account whose visibility
  mask is 3") are left as-is since they are accurate and remain stable
  until the mask value itself changes.

- "..._panics" to "..._fails"
  Covered above. The tests assert Err(CircuitProvingError), so
  execute_and_prove returns an Err, the test process itself never
  panics.

- "we can return `Some((*seed, true, caller))` to avoid having to unwrap
  the `caller_program_id` again in line 290"
  I changed matched_caller_seed from Option<(PdaSeed, bool)> to
  Option<(PdaSeed, bool, ProgramId)>, return the `caller` captured by
  the enclosing and_then from each match arm, and dropped the .expect
  at the consumer site. Bundled with the rename since both touch the
  same branch and a single guest ELF rebuild covers them.

...

This commit is contained in:

Moudy

2026-04-21 01:43:57 +02:00

parent 00cae12d41

commit e8b17eef27

28 changed files with 43 additions and 46 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

artifacts/test_program_methods/burner.bin

BIN

Binary file not shown.

artifacts/test_program_methods/chain_caller.bin

BIN

Binary file not shown.

artifacts/test_program_methods/changer_claimer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/clock_chain_caller.bin

BIN

Binary file not shown.

artifacts/test_program_methods/data_changer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/extra_output.bin

BIN

Binary file not shown.

artifacts/test_program_methods/flash_swap_callback.bin

BIN

Binary file not shown.

artifacts/test_program_methods/flash_swap_initiator.bin

BIN

Binary file not shown.

artifacts/test_program_methods/malicious_authorization_changer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/malicious_caller_program_id.bin

BIN

Binary file not shown.

artifacts/test_program_methods/malicious_self_program_id.bin

BIN

Binary file not shown.

artifacts/test_program_methods/noop.bin

BIN

Binary file not shown.

artifacts/test_program_methods/pda_claimer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/private_pda_claimer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/private_pda_delegator.bin

BIN

Binary file not shown.

artifacts/test_program_methods/simple_balance_transfer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/time_locked_transfer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/two_pda_claimer.bin

BIN

Binary file not shown.

artifacts/test_program_methods/validity_window.bin

BIN

Binary file not shown.

artifacts/test_program_methods/validity_window_chain_caller.bin

BIN

Binary file not shown.