From b396756e8dcd406ebfb63e0e24800361b4ee95f0 Mon Sep 17 00:00:00 2001 From: jonesmarvin8 <83104039+jonesmarvin8@users.noreply.github.com> Date: Mon, 27 Apr 2026 20:07:47 -0400 Subject: [PATCH] addressed some comments --- .../privacy_preserving_transaction/witness_set.rs | 2 +- wallet/src/lib.rs | 13 +++++-------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/nssa/src/privacy_preserving_transaction/witness_set.rs b/nssa/src/privacy_preserving_transaction/witness_set.rs index 86e3fff9..2cd19aac 100644 --- a/nssa/src/privacy_preserving_transaction/witness_set.rs +++ b/nssa/src/privacy_preserving_transaction/witness_set.rs @@ -13,7 +13,7 @@ pub struct WitnessSet { impl WitnessSet { #[must_use] - // TODO: this generates signatures. + // TODO: swap for Keycard signing path. // However. we may need to get signatures from Keycard. pub fn for_message(message: &Message, proof: Proof, private_keys: &[&PrivateKey]) -> Self { let message_hash = message.hash_message(); diff --git a/wallet/src/lib.rs b/wallet/src/lib.rs index c9cf57f1..34633ced 100644 --- a/wallet/src/lib.rs +++ b/wallet/src/lib.rs @@ -414,8 +414,7 @@ impl WalletCore { ) .unwrap(); - let witness_set = Self::sign_privacy_message(&message, &proof, &acc_manager) - .expect("Expect a valid witness set"); + let witness_set = Self::sign_privacy_message(&message, &proof, &acc_manager); let tx = PrivacyPreservingTransaction::new(message, witness_set); let shared_secrets: Vec<_> = private_account_keys @@ -574,14 +573,12 @@ impl WalletCore { message: &nssa::privacy_preserving_transaction::Message, proof: &Proof, acc_manager: &privacy_preserving_tx::AccountManager, - ) -> Result + ) -> nssa::privacy_preserving_transaction::witness_set::WitnessSet { - Ok( - nssa::privacy_preserving_transaction::witness_set::WitnessSet::for_message( + nssa::privacy_preserving_transaction::witness_set::WitnessSet::for_message( message, proof.clone(), - &acc_manager.public_account_auth(), - ), - ) + &acc_manager.public_account_auth()) + } }