refactor(cfgsync): clarify readiness mapping

testing-framework/tools/cfgsync/src/repo.rs

@@ -98,7 +98,10 @@ impl ConfigRepo {
     async fn run(&self) {
         let timeout_duration = self.timeout_duration;
 
-        if timeout(timeout_duration, self.wait_for_hosts()).await == Ok(()) {
+        if timeout(timeout_duration, self.wait_for_hosts())
+            .await
+            .is_ok()
+        {
             println!("All hosts have announced their IPs");
 
             let mut waiting_hosts = self.waiting_hosts.lock().unwrap();

testing-framework/tools/cfgsync/src/server.rs

@@ -259,19 +259,28 @@ fn override_api_ports(config: &mut Value, ports: &PortOverrides) {
 }
 
 fn inject_da_assignations(config: &mut Value, membership: &nomos_node::NomosDaMembership) {
+    struct SubnetAssignment {
+        subnet_id: String,
+        peers: Vec<String>,
+    }
+
     fn convert_subnet_to_assignment(
         subnet_id: impl ToString,
         members: impl IntoIterator<Item = impl ToString>,
-    ) -> (String, Vec<String>) {
+    ) -> SubnetAssignment {
-        let peer_strings: Vec<String> = members.into_iter().map(|peer| peer.to_string()).collect();
+        let peers = members.into_iter().map(|peer| peer.to_string()).collect();
 
-        (subnet_id.to_string(), peer_strings)
+        SubnetAssignment {
+            subnet_id: subnet_id.to_string(),
+            peers,
+        }
     }
 
     let subnetworks = membership.subnetworks();
     let assignations: std::collections::HashMap<String, Vec<String>> = subnetworks
         .into_iter()
         .map(|(subnet_id, members)| convert_subnet_to_assignment(subnet_id, members))
+        .map(|assignment| (assignment.subnet_id, assignment.peers))
         .collect();
 
     if let Some(membership) = config.pointer_mut("/da_network/membership") {