From a5b7c54ccdf9f787ec3d0db0c783c651c8a6c8b1 Mon Sep 17 00:00:00 2001 From: mjalalzai <33738574+MForensic@users.noreply.github.com> Date: Thu, 21 Sep 2023 19:43:37 -0700 Subject: [PATCH] Safe block --- carnot/carnot-vote-aggregation.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/carnot/carnot-vote-aggregation.py b/carnot/carnot-vote-aggregation.py index 4ff753e..2f585a4 100644 --- a/carnot/carnot-vote-aggregation.py +++ b/carnot/carnot-vote-aggregation.py @@ -256,7 +256,10 @@ class Carnot: return self.genesis_block() def block_is_safe(self, block: Block) -> bool: - if isinstance(block.qc, (StandardQc,)): + if isinstance(block.qc, StandardQc): return block.view_num == block.qc.view() + 1 - if isinstance(block.qc, (AggregateQc,)): - return (block.view_num == block.qc.view() + 1) and block.extends(self.latest_committed_block()) + elif isinstance(block.qc, AggregateQc): + return block.view_num == block.qc.view() + 1 and block.extends(self.latest_committed_block()) + else: + return False +