From 8f51c339fd4d4a3e30c361a20cc118ce20f9f39f Mon Sep 17 00:00:00 2001 From: David Rusu Date: Sun, 7 Jun 2026 12:00:25 -0400 Subject: [PATCH] rename: arm64 -> aarch64 in PIC artifact naming for triple consistency Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/build-pic-archives.yml | 8 ++++---- crates/download_rapidsnark.sh | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-pic-archives.yml b/.github/workflows/build-pic-archives.yml index 058aa05..56491d2 100644 --- a/.github/workflows/build-pic-archives.yml +++ b/.github/workflows/build-pic-archives.yml @@ -37,9 +37,9 @@ jobs: slug: rapidsnark-linux-x86_64-pic # Empty => cmake defaults to the x86_64 field-arithmetic asm (nasm). target_platform: "" - - arch: arm64 + - arch: aarch64 runner: ubuntu-22.04-arm - slug: rapidsnark-linux-arm64-pic + slug: rapidsnark-linux-aarch64-pic # aarch64 => cmake uses the AArch64 .s field arithmetic, not x86 nasm. target_platform: "aarch64" runs-on: ${{ matrix.runner }} @@ -86,8 +86,8 @@ jobs: fmt=$(objdump -f rs/bp/src/libfr.a | grep -m1 'file format') echo "libfr.a -> $fmt" case "${{ matrix.arch }}" in - x86_64) echo "$fmt" | grep -q 'elf64-x86-64' || { echo "::error::expected x86-64 objects"; exit 1; } ;; - arm64) echo "$fmt" | grep -q 'elf64-littleaarch64' || { echo "::error::expected aarch64 objects"; exit 1; } ;; + x86_64) echo "$fmt" | grep -q 'elf64-x86-64' || { echo "::error::expected x86-64 objects"; exit 1; } ;; + aarch64) echo "$fmt" | grep -q 'elf64-littleaarch64' || { echo "::error::expected aarch64 objects"; exit 1; } ;; esac echo "architecture OK for ${{ matrix.arch }}" diff --git a/crates/download_rapidsnark.sh b/crates/download_rapidsnark.sh index d64ee87..6c32f17 100755 --- a/crates/download_rapidsnark.sh +++ b/crates/download_rapidsnark.sh @@ -31,7 +31,7 @@ arch=$(echo "$TARGET" | cut -d'-' -f1) # Map the rust target triple to the release asset slug and its hosting base URL. case "$TARGET" in x86_64-*-linux-*) asset="rapidsnark-linux-x86_64-pic-$VERSION"; base_url="$FORK_BASE" ;; - aarch64-*-linux-gnu*) asset="rapidsnark-linux-arm64-pic-$VERSION"; base_url="$FORK_BASE" ;; + aarch64-*-linux-gnu*) asset="rapidsnark-linux-aarch64-pic-$VERSION"; base_url="$FORK_BASE" ;; aarch64-linux-android) asset="rapidsnark-android-arm64-$VERSION"; base_url="$IDEN3_BASE" ;; x86_64-linux-android) asset="rapidsnark-android-x86_64-$VERSION"; base_url="$IDEN3_BASE" ;; aarch64-apple-darwin) asset="rapidsnark-macOS-arm64-$VERSION"; base_url="$IDEN3_BASE" ;;