From e38b76e020a7a07f259d73449fc97ed4aabe2cb6 Mon Sep 17 00:00:00 2001 From: David Rusu Date: Mon, 19 Aug 2024 21:52:33 +0400 Subject: [PATCH] goas: don't expose nullifier nonce/commitment bytes --- goas/atomic_asset_transfer/executor/src/lib.rs | 2 +- goas/cl/cl/src/nullifier.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/goas/atomic_asset_transfer/executor/src/lib.rs b/goas/atomic_asset_transfer/executor/src/lib.rs index 1b7e57a..7e4937f 100644 --- a/goas/atomic_asset_transfer/executor/src/lib.rs +++ b/goas/atomic_asset_transfer/executor/src/lib.rs @@ -232,7 +232,7 @@ mod tests { let bind = OutputWitness::public( NoteWitness::basic(32, *common::ZONE_CL_FUNDS_UNIT), - cl::NullifierNonce([0u8; 32]), + cl::NullifierNonce::random(&mut rng), ); let mut alice = common::new_account(&mut rng); diff --git a/goas/cl/cl/src/nullifier.rs b/goas/cl/cl/src/nullifier.rs index 295b674..ada9f81 100644 --- a/goas/cl/cl/src/nullifier.rs +++ b/goas/cl/cl/src/nullifier.rs @@ -25,13 +25,13 @@ pub struct NullifierSecret(pub [u8; 16]); // can be provided to anyone wishing to transfer // you a note #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] -pub struct NullifierCommitment(pub [u8; 32]); +pub struct NullifierCommitment([u8; 32]); // To allow users to maintain fewer nullifier secrets, we // provide a nonce to differentiate notes controlled by the same // secret. Each note is assigned a unique nullifier nonce. #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] -pub struct NullifierNonce(pub [u8; 32]); +pub struct NullifierNonce([u8; 32]); // The nullifier attached to input notes to prove an input has not // already been spent.