fix: remove commented code

This commit is contained in:
Roman 2025-01-13 19:11:34 +08:00
parent 01e22b335b
commit ac2f1fc8a7
No known key found for this signature in database
GPG Key ID: B8FE070B54E11B75
2 changed files with 2 additions and 10 deletions

View File

@ -35,7 +35,7 @@ class DockerManager:
logger.debug(f"Network {network_name} created")
return network
def start_container(self, image_name, port_bindings, args, log_path, container_ip, volumes, entrypoint, remove_container=True, name=None):
def start_container(self, image_name, port_bindings, args, log_path, volumes, entrypoint, remove_container=True, name=None):
cli_args = []
for key, value in args.items():
if isinstance(value, list): # Check if value is a list
@ -45,8 +45,6 @@ class DockerManager:
else:
cli_args.append(f"--{key}={value}") # Add a single command
# port_bindings = {f"{port}/tcp": ("", port) for port in ports}
# port_bindings_for_log = " ".join(f"-p {port}:{port}" for port in ports)
cli_args_str_for_log = " ".join(cli_args)
logger.debug(f"docker run -i -t {port_bindings} {image_name} {cli_args_str_for_log}")
container = self._client.containers.run(
@ -62,10 +60,6 @@ class DockerManager:
network=NETWORK_NAME,
)
# network = self._client.networks.get(NETWORK_NAME)
# logger.debug(f"docker network connect --ip {container_ip} {NETWORK_NAME} {container.id}")
# network.connect(container, ipv4_address=container_ip)
logger.debug(f"Container started with ID {container.short_id}. Setting up logs at {log_path}")
log_thread = threading.Thread(target=self._log_container_output, args=(container, log_path))
log_thread.daemon = True

View File

@ -1,6 +1,5 @@
import os
from src.libs.common import delay
from src.libs.custom_logger import get_custom_logger
from tenacity import retry, stop_after_delay, wait_fixed
@ -71,10 +70,9 @@ class NomosNode:
port_bindings=self._port_map,
args=default_args,
log_path=self._log_path,
container_ip=self._ext_ip,
volumes=self._volumes,
entrypoint=self._entrypoint,
remove_container=False,
remove_container=True,
name=self._container_name,
)