Improve build function names.

This commit is contained in:
Alejandro Cabeza Romero 2026-05-07 14:37:09 +02:00
parent 9523b53186
commit c28a2cde4a
No known key found for this signature in database
GPG Key ID: DA3D14AE478030FD
2 changed files with 8 additions and 7 deletions

View File

@ -31,10 +31,11 @@ lbc-signature-sys = { default-features = false, package = "logos-blockchain-circ
lbc-types = { default-features = false, package = "logos-blockchain-circuits-types", path = "./logos-blockchain-circuits-types" }
# External
flate2 = "^1"
flate2 = "^1.1"
libc = "^0.2"
tar = "^0.4"
ureq = "^3.3"
bytes = "^1.11"
# Sourced from https://github.com/logos-co/nomos/blob/main/Cargo.toml
[workspace.lints.clippy]

View File

@ -6,18 +6,18 @@ use ureq::http::Response;
static REPO: &str = "logos-blockchain/logos-blockchain-circuits";
static ARTIFACT_PREFIX: &str = "logos-blockchain-circuits";
fn get_artifact_name(version: &str, os: &str, arch: &str) -> String {
fn build_artifact_name(version: &str, os: &str, arch: &str) -> String {
format!("{ARTIFACT_PREFIX}-v{version}-{os}-{arch}")
}
fn get_artifact_url(version: &str, os: &str, arch: &str) -> String {
let artifact = get_artifact_name(version, os, arch);
fn build_artifact_url(version: &str, os: &str, arch: &str) -> String {
let artifact = build_artifact_name(version, os, arch);
let artifact_tar_gz = format!("{artifact}.tar.gz");
format!("https://github.com/{REPO}/releases/download/v{version}/{artifact_tar_gz}")
}
fn fetch_library(version: &str, os: &str, arch: &str, lib_var_name: &str) -> Response<Body> {
let url = get_artifact_url(version, os, arch);
let url = build_artifact_url(version, os, arch);
// We skip checksum verification intentionally.
// Hardcoded hashes would protect against a silently replaced release asset, but require a
// two-step release (build → hash → commit → tag) which feels overkill for a first-party
@ -44,7 +44,7 @@ fn unpack_library(
.unpack(output_dir)
.expect("Failed to unpack the downloaded archive.");
let unpacked_artifact_path = output_dir.join(get_artifact_name(version, os, arch));
let unpacked_artifact_path = output_dir.join(build_artifact_name(version, os, arch));
let unpacked_library_directory = unpacked_artifact_path.join(circuit_name);
assert!(
@ -63,7 +63,7 @@ fn provision_library(circuit_name: &str, lib_var_name: &str) -> PathBuf {
let out_dir = PathBuf::from(std::env::var("OUT_DIR").unwrap());
let expected_library_directory = out_dir
.join(get_artifact_name(version, &os, &arch))
.join(build_artifact_name(version, &os, &arch))
.join(circuit_name);
if expected_library_directory.is_dir() {
println!(