logos-blockchain/logos-blockchain-circuits
1
0
Fork 0
mirror of https://github.com/logos-blockchain/logos-blockchain-circuits.git synced 2026-07-03 07:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid double free

Browse Source
This commit is contained in:
Antonio Antonino 2026-06-09 12:35:52 +02:00
parent 4cd1377d05
commit 8a4a01b92d
No known key found for this signature in database
GPG Key ID: 70CC1DF6BCF7E76D
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
.github/resources/witness-generator/fix_calcwit_leak.sh vendored
View File

@ -33,20 +33,15 @@ perl -0777 -i -pe '
// logos: free per-call allocations. circom leaves this destructor empty
// because the generated binary exits after one witness; we call the
// generated code in-process as a library, so without these frees every
// witness-generation call leaks signalValues (megabytes) + componentMemory
// + inputSignalAssigned. The per-component frees mirror circoms own
// release_memory_component (guarded), so they are safe to run once here.
for (int i = 0; i < get_number_of_components(); i++) {
if (componentMemory[i].subcomponents) delete[] componentMemory[i].subcomponents;
if (componentMemory[i].subcomponentsParallel) delete[] componentMemory[i].subcomponentsParallel;
if (componentMemory[i].outputIsSet) delete[] componentMemory[i].outputIsSet;
if (componentMemory[i].mutexes) delete[] componentMemory[i].mutexes;
if (componentMemory[i].cvs) delete[] componentMemory[i].cvs;
if (componentMemory[i].sbct) delete[] componentMemory[i].sbct;
}
delete[] componentMemory;
// witness-generation call leaks signalValues (megabytes), componentMemory
// and inputSignalAssigned. These three are allocated once in the constructor
// and freed nowhere else. NOTE: the per-component sub-buffers
// (subcomponents/outputIsSet/mutexes/...) are already released during the
// witness computation by circoms own release_memory_component, so they must
// NOT be freed here -- doing so double-frees.
delete[] signalValues;
delete[] inputSignalAssigned;
delete[] componentMemory;
}};
my $n = (s/Circom_CalcWit::~Circom_CalcWit\s*\(\s*\)\s*\{.*?\n\}/$body/s);
die "fix_calcwit_leak: could not locate ~Circom_CalcWit() destructor\n" unless $n == 1;