mirror of
https://github.com/logos-blockchain/lez-programs.git
synced 2026-08-25 06:01:11 +00:00
r4bbit
8e359c4010
Route pool creation through the redesigned createPool op and retire the old
create-flow machinery. Add-liquidity stays on the legacy submitNewPosition.
Module (amm_module):
- createPool becomes a single-param envelope: it reads the caller-provided
lpHoldingId from the request (a new pool has no pre-existing LP holding),
dropping the requires-fresh-lp handshake — the module never creates wallet
accounts. Returns { status, error, transactionId }; unlike the swaps, a
submit failure carries a code so the UI can explain why.
Backend (AmmUiBackend):
- Expose liquidityQuote (read-only preview) and createPool slots. createPool
guards on the app's wallet-open state, forwards the request, and refreshes
balances on success. No account creation here.
UI (liquidity flow/form):
- NewPositionFlow.confirm() branches on the missing-pool signal: create ->
createPool (mint a fresh public LP account via createAccountPublic, then
submit); add -> unchanged submitNewPosition. Hex transactionId accepted.
- submissionSnapshot supplies canonical-order holdingAId/holdingBId.
- (liquidityQuote is wired to the backend but the create preview still rides
the legacy quote for now.)
Cleanup: the pool-creation confirmation poll is orphaned now that create no
longer submits via submitNewPosition. It polled the pool account by re-quoting
until poolStatus flipped to active_pool — a stopgap for the missing
transactionStatus/poll_tx on the lez module. Removed pendingPoolProbes,
poolPoller, watchPoolCreation, pollPendingPool, finishPoolProbe,
rotate/removePendingPool, pairKey, matchesSelectedPair,
selectedPoolCreationPending, poolActivated, the poolCreationPending state,
acceptPoolActivation, and their now-obsolete tests.
AMM UI tests
UI-driven tests for the AMM app. swap.mjs drives the running app through the
QML inspector (framework from
logos-co/logos-qt-mcp): it selects
two tokens, enters an amount, submits a swap, and verifies the pool reserves
changed on-chain.
Isolation
Test runs never touch your personal setup. Everything test-related lives under
apps/amm/tests/testnet/ and is git-ignored:
| Concern | Test (isolated) | Your local dev |
|---|---|---|
| Wallet home | apps/amm/tests/testnet/.wallet/ |
~/.lee/wallet/ |
| Token config | apps/amm/tests/testnet/amm-tokens.json |
apps/amm/amm-tokens.json |
testnet/setup-amm-testnet.sh bootstraps an isolated wallet from a fixed
mnemonic (test test … junk) so the token/holding account ids are
deterministic and reproducible across machines, then deploys the programs,
creates a seeded pool, and writes the test token config.
Full isolated run
From the repo root, with wallet / spel / cargo / nix on PATH, a
local sequencer running, and the guest binaries built (make build-programs):
# 0. Once: build the JS test framework (symlinked where swap.mjs expects it)
nix build .#test-framework -o apps/amm/result-mcp
# 1. Bootstrap the isolated wallet + deploy programs + create the pool.
# Writes apps/amm/tests/testnet/{.wallet, amm-tokens.json}. Nothing else is touched.
TEST_SEQUENCER_ADDR=http://127.0.0.1:3040 apps/amm/tests/testnet/setup-amm-testnet.sh
# 2. Terminal 1 — launch the UI against ONLY the isolated wallet + test tokens.
LEE_WALLET_HOME_DIR=$(pwd)/apps/amm/tests/testnet/.wallet \
AMM_PROGRAM_BIN=$(pwd)/programs/amm/methods/guest/target/riscv32im-risc0-zkvm-elf/docker/amm.bin \
TOKENS_CONFIG=$(pwd)/apps/amm/tests/testnet/amm-tokens.json \
nix run .#amm-ui
# 3. Terminal 2 — drive the swap test; watch it click through the live UI.
node apps/amm/tests/swap.mjs
Headless CI variant (no window, launches the app itself, pass/fail only):
nix build .#integration-test -L
Notes
- Wallet password. The wallet's key storage is encrypted with a password —
the one you enter to unlock it (the UI's Connect modal) so the app can
sign transactions. First-time setup reads a throwaway password (the script
feeds it via stdin, so it doesn't block), then
restore-keysrebuilds the wallet from the test mnemonic and sets the real password toTEST_WALLET_PASSWORD(defaulttest). So unlock the UI withtest. Prefer no password? Run withTEST_WALLET_PASSWORD=""and unlock with an empty password. - Re-bootstrap.
FORCE_BOOTSTRAP=1 apps/amm/tests/testnet/setup-amm-testnet.shre-restores the isolated.wallet(rewrites only that directory). - Overrides.
TEST_WALLET_HOME,TEST_MNEMONIC,TEST_WALLET_PASSWORD,TEST_WALLET_DEPTH,TEST_SEQUENCER_ADDR— see the script header. - Framework location.
swap.mjsloads../result-mcpby default; override withLOGOS_QT_MCP=/abs/path/to/result-mcp. - Artifacts. On failure
swap.mjsprints theSwapCardstate and savesapps/amm/tests/swap-*.png(git-ignored) for inspection.
Files
swap.mjs— the end-to-end swap UI test.testnet/setup-amm-testnet.sh— isolated testnet + wallet bootstrap.qml/,cpp/— the module's own QML/C++ unit tests.