From 1f70ed51bac9e3ba41b0126fcb8023e803748f76 Mon Sep 17 00:00:00 2001 From: Ricardo Guilherme Schmidt <3esmit@gmail.com> Date: Fri, 17 Jul 2026 20:07:04 -0300 Subject: [PATCH] fix(amm): reject failed identity responses --- apps/amm/src/AmmUiBackend.cpp | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/apps/amm/src/AmmUiBackend.cpp b/apps/amm/src/AmmUiBackend.cpp index 3d2e187..e6207cf 100644 --- a/apps/amm/src/AmmUiBackend.cpp +++ b/apps/amm/src/AmmUiBackend.cpp @@ -273,10 +273,17 @@ void AmmUiBackend::probeNetworkIdentity() return; } - const QByteArray payload = reply->readAll(); - const QString actual = devnet - ? channelIdFromResponse(payload) - : blockHashFromResponse(payload); + const QVariant statusValue = reply->attribute( + QNetworkRequest::HttpStatusCodeAttribute); + const int status = statusValue.toInt(); + const bool successfulResponse = reply->error() == QNetworkReply::NoError + && statusValue.isValid() + && status >= 200 + && status < 300; + const QByteArray payload = successfulResponse ? reply->readAll() : QByteArray(); + const QString actual = successfulResponse + ? (devnet ? channelIdFromResponse(payload) : blockHashFromResponse(payload)) + : QString(); m_network.finishIdentityProbe(actual); const int retryDelay = m_network.identityRetryDelayMs(); if (retryDelay > 0)