mirror of
https://github.com/embarklabs/embark.git
synced 2025-01-09 13:26:10 +00:00
3693ebd90d
Many packages in the monorepo did not specify all of their dependencies; they
were effectively relying on resolution in the monorepo's root
`node_modules`. In a production release of `embark` and `embark[js]-*` packages
this can lead to broken packages.
To fix the problem currently and to help prevent it from happening again, make
use of the `eslint-plugin-import` package's `import/no-extraneous-dependencies`
and `import/no-unresolved` rules. In the root `tslint.json` set
`"no-implicit-dependencies": true`, wich is the tslint equivalent of
`import/no-extraneous-dependencies`; there is no tslint equivalent for
`import/no-unresolved`, but we will eventually replace tslint with an eslint
configuration that checks both `.js` and `.ts` files.
For `import/no-unresolved` to work in our monorepo setup, in most packages add
an `index.js` that has:
```js
module.exports = require('./dist'); // or './dist/lib' in some cases
```
And point `"main"` in `package.json` to `"./index.js"`. Despite what's
indicated in npm's documentation for `package.json`, it's also necessary to add
`"index.js"` to the `"files"` array.
Make sure that all `.js` files that can and should be linted are in fact
linted. For example, files in `packages/embark/src/cmd/` weren't being linted
and many test suites weren't being linted.
Bump all relevant packages to `eslint@6.8.0`.
Fix all linter errors that arose after these changes.
Implement a `check-yarn-lock` script that's run as part of `"ci:full"` and
`"qa:full"`, and can manually be invoked via `yarn cylock` in the root of the
monorepo. The script exits with error if any specifiers are found in
`yarn.lock` for `embark[js][-*]` and/or `@embarklabs/*` (with a few exceptions,
cf. `scripts/check-yarn-lock.js`).
96 lines
2.2 KiB
JavaScript
96 lines
2.2 KiB
JavaScript
/*
|
|
* dependencies of this config should be specified in `./package.json` relative
|
|
* to this config file (which should be in the root of the monorepo);
|
|
* yarn-workspace hoisting re: dev/Deps specified in
|
|
* `packages/utils/collective/package.json` is not reliable re: dependencies of
|
|
* this root-level config being resolvable (with correct versions) from the
|
|
* monorepo root
|
|
*/
|
|
|
|
const cloneDeep = require('lodash.clonedeep');
|
|
|
|
module.exports = (api) => {
|
|
const env = api.env();
|
|
|
|
const base = {
|
|
babelrcRoots: [
|
|
'.',
|
|
'packages/*'
|
|
],
|
|
plugins: [
|
|
'babel-plugin-macros',
|
|
[
|
|
'@babel/plugin-proposal-decorators', {
|
|
legacy: true
|
|
}
|
|
],
|
|
'@babel/plugin-proposal-export-namespace-from',
|
|
'@babel/plugin-proposal-export-default-from',
|
|
'@babel/plugin-syntax-dynamic-import',
|
|
[
|
|
'@babel/plugin-proposal-class-properties', {
|
|
loose: true
|
|
}
|
|
],
|
|
'@babel/plugin-proposal-nullish-coalescing-operator',
|
|
'@babel/plugin-proposal-optional-chaining',
|
|
[
|
|
'@babel/plugin-transform-runtime', {
|
|
corejs: 3
|
|
}
|
|
]
|
|
],
|
|
presets: [
|
|
'@babel/preset-env',
|
|
'@babel/preset-typescript'
|
|
]
|
|
};
|
|
|
|
if (env === 'base' || env.startsWith('base:')) {
|
|
return base;
|
|
}
|
|
|
|
const browser = cloneDeep(base);
|
|
browser.plugins[browser.plugins.length - 1][1].useESModules = true;
|
|
browser.presets[0] = [
|
|
browser.presets[0], {
|
|
corejs: 3,
|
|
modules: false,
|
|
shippedProposals: true,
|
|
targets: {browsers: ['last 1 version', 'not dead', '> 0.2%']},
|
|
useBuiltIns: 'usage'
|
|
}
|
|
];
|
|
|
|
if (env === 'browser' || env.startsWith('browser:')) {
|
|
return browser;
|
|
}
|
|
|
|
const node = cloneDeep(base);
|
|
node.plugins.splice(
|
|
node.plugins.indexOf('@babel/plugin-syntax-dynamic-import') + 1,
|
|
0,
|
|
'babel-plugin-dynamic-import-node'
|
|
);
|
|
node.presets[0] = [
|
|
node.presets[0], {
|
|
corejs: 3,
|
|
shippedProposals: true,
|
|
targets: {node: '10.17.0'},
|
|
useBuiltIns: 'usage'
|
|
}
|
|
];
|
|
|
|
if (env === 'node' || env.startsWith('node:')) {
|
|
return node;
|
|
}
|
|
|
|
const test = cloneDeep(node);
|
|
|
|
if (env === 'test') {
|
|
return test;
|
|
}
|
|
|
|
return {};
|
|
};
|