mirror of
https://github.com/embarklabs/embark.git
synced 2025-01-09 05:23:26 +00:00
3693ebd90d
Many packages in the monorepo did not specify all of their dependencies; they
were effectively relying on resolution in the monorepo's root
`node_modules`. In a production release of `embark` and `embark[js]-*` packages
this can lead to broken packages.
To fix the problem currently and to help prevent it from happening again, make
use of the `eslint-plugin-import` package's `import/no-extraneous-dependencies`
and `import/no-unresolved` rules. In the root `tslint.json` set
`"no-implicit-dependencies": true`, wich is the tslint equivalent of
`import/no-extraneous-dependencies`; there is no tslint equivalent for
`import/no-unresolved`, but we will eventually replace tslint with an eslint
configuration that checks both `.js` and `.ts` files.
For `import/no-unresolved` to work in our monorepo setup, in most packages add
an `index.js` that has:
```js
module.exports = require('./dist'); // or './dist/lib' in some cases
```
And point `"main"` in `package.json` to `"./index.js"`. Despite what's
indicated in npm's documentation for `package.json`, it's also necessary to add
`"index.js"` to the `"files"` array.
Make sure that all `.js` files that can and should be linted are in fact
linted. For example, files in `packages/embark/src/cmd/` weren't being linted
and many test suites weren't being linted.
Bump all relevant packages to `eslint@6.8.0`.
Fix all linter errors that arose after these changes.
Implement a `check-yarn-lock` script that's run as part of `"ci:full"` and
`"qa:full"`, and can manually be invoked via `yarn cylock` in the root of the
monorepo. The script exits with error if any specifiers are found in
`yarn.lock` for `embark[js][-*]` and/or `@embarklabs/*` (with a few exceptions,
cf. `scripts/check-yarn-lock.js`).
57 lines
1.4 KiB
JavaScript
57 lines
1.4 KiB
JavaScript
// there seems to be a bug in yarn whereby forwarding arguments with -- like so:
|
|
// $ yarn monorun [...] -- --foo
|
|
// results in [...] being stripped away; can workaround with:
|
|
// $ yarn monorun -- [...] -- --foo
|
|
// but note that yarn warns about a future behavioral change re: yarn and --
|
|
|
|
const {dirname} = require('path');
|
|
const {spawn} = require('child_process');
|
|
const {sync: findUp} = require('find-up');
|
|
const minimist = require('minimist');
|
|
|
|
const monorepoRootPath = dirname(findUp('lerna.json'));
|
|
|
|
let cliArgs = process.argv.slice(2);
|
|
|
|
const options = minimist(
|
|
cliArgs,
|
|
{boolean: [
|
|
'include-filtered-dependents',
|
|
'include-filtered-dependencies',
|
|
'no-bail',
|
|
'no-prefix',
|
|
'no-private',
|
|
'no-progress',
|
|
'no-sort',
|
|
'parallel',
|
|
'reject-cycles',
|
|
'stream'
|
|
]}
|
|
);
|
|
|
|
Object.keys(options).forEach(key => {
|
|
const invKey = key.slice(3);
|
|
if (key.startsWith('no-') && options.hasOwnProperty(invKey)) {
|
|
options[key] = !options[invKey];
|
|
delete options[invKey];
|
|
}
|
|
});
|
|
|
|
process.env.EMBARK_COLLECTIVE_OPTIONS = JSON.stringify(options);
|
|
|
|
if (cliArgs.includes('--scope')) {
|
|
cliArgs.push('--scope', 'embark-collective');
|
|
}
|
|
|
|
const npxCmd = process.platform === 'win32' ? 'npx.cmd': 'npx';
|
|
const subp = spawn(npxCmd, [
|
|
'lerna',
|
|
'run',
|
|
...cliArgs
|
|
], {
|
|
cwd: monorepoRootPath,
|
|
stdio: 'inherit'
|
|
});
|
|
|
|
subp.on('close', code => process.exit(code));
|