mirror of
https://github.com/embarklabs/embark.git
synced 2025-02-26 12:25:49 +00:00
9fad77715b
Add the ability to pass an error in the callback of an event action. Currently, event actions could either pass back a an error OR a result, but not both, and with no way to distinguish between the two parameters. This PR adds the ability to pass an error as the first parameter of the action callback. An example of a use case that this fixed: errors on `deployIf` were silently swallowed, which has now been fixed. All instances of `events.request(“deploy:contracts”)` were given an `error` parameter in their callback, and errors printed if it is not undefined. All instances of `registerActionForEvent` were combed to ensure any callbacks were passing the expected error and result.