embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
embark/packages/plugins/basic-pipeline
History
Pascal Precht 031ebe8bb2 fix(plugins/basic-pipeline): ensure correct webpack config is loaded 
When making `basic-pipeline` in 948956ab1f we've introduced a regression
and with this fix, a behaviour change as well::

1. The `webpackConfigName` passed to `Engine` is completely ignored, caused it to be
  `undefined` down the line when the plugin tries to do its work (we essentially broke bundling)
2. With that configuration being ignored, we need a new way to make this configurable.
  Since `basic-pipeline` is now a true plugin, it makes sense for itself to have configuration
  options for that, while still providing decent defaults.
3. The trickly thing is that `webpackConfigName` used to have different values per command.
  For example `build` used to use `production` while `run` used `development` as config.
4. This commit introduces new configuration options for `basic-pipeline` that lets users configure
the `webpackConfigName` per environment:

```json
// embark.json
{
  ...
  "plugins": {
    "embark-basic-pipeline": {
      "development": {
        webpackConfigName: "development"
      },
      "production": {
        webpackConfigName: "production"
      }
    }
  }
}
```
^ These are also the defaults. So not providing this configuration will make
Embark imply it.

Notice that this does not account for the "different config per command" case.
This means `embark build` will also use `development` by default.

Prior to this commit and the one mentioned above, the `webpackConfigName` was configurable
through the CMD `--pipeline` option. Since this a) no longer a built-in feature
and b) ignored at the moment anyways, I've removed the `--pipeline` options
from all commands as well.

BREAKING CHANGES

The commands `embark eject-webpack` and `embark eject-build-config` are no longer available.
The `--pipeline` option has been removed from all commands that used to support it.
 		2020-03-23 15:19:58 +01:00
..
src fix(plugins/basic-pipeline): ensure correct webpack config is loaded 2020-03-23 15:19:58 +01:00
test fix: ensure that packages properly specify their dependencies 2020-02-25 14:52:10 -06:00
.babelrc.js fix: fix windows build for pipeline and embarkjs (#1971) 2019-10-16 09:07:42 -04:00
.npmrc refactor(@embark/embarkjs): move module into own package (#1945) 2019-10-14 16:05:17 +09:00
CHANGELOG.md chore(prerelease): 5.3.0-nightly.12 2020-03-21 00:15:48 +00:00
README.md chore: update site urls 2020-01-28 12:07:17 -05:00
index.js fix: ensure that packages properly specify their dependencies 2020-02-25 14:52:10 -06:00
package.json chore(prerelease): 5.3.0-nightly.12 2020-03-21 00:15:48 +00:00
tsconfig.json build: implement collective typecheck 2019-12-13 13:59:47 -05:00

README.md

embark-basic-pipeline

Basic pipeline for Embark that builds a DApp's frontend assets using webpack

Visit framework.embarklabs.io to get started with Embark.

Contracts in test/fixture/contracts are from OpenZeppelin and Gnosis Prediction Markets