mirror of
https://github.com/embarklabs/embark.git
synced 2025-01-12 14:54:57 +00:00
0eaad43e4d
This PR fixes a number of issues relating to the cockpit console. #### Console commands display in cockpit console Fix cockpit console not displaying console usage commands that included “<usage option>”. For example “resolve <name>” would not display the “<name>” part, as it was attempting to write this in as HTML (ansi-to-html conversion). This was fixed by replacing any instances of “<usage>” with “[usage]”. Please note that future usage strings should not contain text wrapped in “<>”. #### Autosuggestions for “web.eth.” not appearing Fix “web3.eth.” not suggesting members of `web3.eth`. This was due to a `Object.keys(web3.eth)` throwing `'getOwnPropertyDescriptor' on proxy: trap returned descriptor for property 'defaultAccount' that is incompatible with the existing property in the proxy target` in the console. Changing `Object.keys` to `Object.getOwnPropertyDescriptor` solved the problem. #### Fix autosuggestion of known console commands (ie from plugins) Fix known console commands (ie from plugins) not being autosuggested. For example, typing “web”, should autosuggest `webserver start/stop`, `log webserver on`, and `log webserver off`. This PR adds in support for registered console commands (from plugins).