mirror of https://github.com/embarklabs/embark.git
030fb4acc6
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web3 v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the resolved return value's type using TypeScript's `as` operator. |
||
|---|---|---|
| .. | ||
| 2017-06-28-embark-2-5-released.md | ||
| 2017-10-25-embark-2-6-released.md | ||
| 2018-05-04-embark-3-0-released.md | ||
| 2018-06-20-embark-3-1-released.md | ||
| 2018-09-27-how-to-create-a-token-factory-with-embark-part-1.md | ||
| 2018-10-27-how-to-create-a-token-factory-with-embark-part-2.md | ||
| 2019-01-23-building-smart-contract-only-dapps.md | ||
| 2019-01-28-running-embark-tests-on-a-continuous-integration-server.md | ||
| 2019-02-04-building-a-decentralized-reddit-with-embark-part-1.md | ||
| 2019-02-11-building-a-decentralized-reddit-with-embark-part-2.md | ||
| 2019-02-18-building-a-decentralized-reddit-with-embark-part-3.md | ||
| 2019-03-18-upgrading-to-embark-4.md | ||
| 2019-03-19-introducing-embark-4.md | ||
| 2019-07-23-whats-new-in-embark-4.1.md | ||
| 2019-11-18-nim-vs-crystal-part-1-performance-interoperability.md | ||
| 2019-11-21-nim-vs-crystal-part-2-threading-tooling.md | ||
| 2019-11-28-nim-vs-crystal-part-3-cryto-dapps-p2p.md | ||
| 2019-12-09-web3-what-are-your-options.md | ||
| 2020-01-09-take-back-the-web-hackathon.md | ||
| 2020-01-13-announcing-embark-5.md | ||