mirror of
https://github.com/embarklabs/embark.git
synced 2025-01-09 13:26:10 +00:00
991d958436
[PR 1318][PR1318] introduces a monorepo member that's used as a DApp dependency, but the present arrangement whereby `test_dapps/` is an embedded monorepo makes it difficult to develop and test such packages in tandem with changes to `test_dapps/packages/*`. Reorganize `test_dapps/*` as members of the root monorepo and make various adjustments accordingly. This makes it easy to develop test dapps and any packages they depend on simultaneously, but we lose the CI/QA arrangement where test dapps are run with an embark installed from fresh tarballs. That arrangement, which is quite worthwhile as a means to detect problems arising from transitive dependencies as soon as possible, will be re-introduced in another PR, possibly involving an auxiliary repository such as embark-framework/dapp-bin. Since the `package.json` `"test"` scripts of `test_dapps/*` are now kicked off as part of `yarn test` in the root, and since port allocation isn't fully dynamic, it's important to run `yarn test` with `lerna run`'s `--concurrency=1` option. For the same reasons, the root `ci` and `qa` scripts are similarly restricted. In the future, this setup can be refactored and improved, along with use of `lerna run`'s `--since` option to increase testing efficiency in CI. [PR1318]: https://github.com/embark-framework/embark/pull/1318
36 lines
1.2 KiB
JavaScript
36 lines
1.2 KiB
JavaScript
/*globals describe, it*/
|
|
const fs = require('fs-extra');
|
|
const assert = require('assert');
|
|
|
|
describe('http contracts', () => {
|
|
it('should have downloaded the file in .embark/contracts', (done) => {
|
|
const contractPath = '.embark/contracts/status-im/contracts/151-embark31/contracts/token/StandardToken.sol';
|
|
fs.access(contractPath, (err) => {
|
|
if (err) {
|
|
assert.fail(contractPath + ' was not downloaded');
|
|
}
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should have downloaded the file import file too', (done) => {
|
|
const contractImportPath = '.embark/contracts/status-im/contracts/151-embark31/contracts/token/ERC20Token.sol';
|
|
fs.access(contractImportPath, (err) => {
|
|
if (err) {
|
|
assert.fail(contractImportPath + ' was not downloaded');
|
|
}
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should have downloaded the http import in SimpleStorageWithHttpImport', (done) => {
|
|
const contractImportPath = '.embark/contracts/embark-framework/embark/master/test_dapps/packages/contracts_app/contracts/ownable.sol';
|
|
fs.access(contractImportPath, (err) => {
|
|
if (err) {
|
|
assert.fail(contractImportPath + ' was not downloaded');
|
|
}
|
|
done();
|
|
});
|
|
});
|
|
});
|