mirror of
https://github.com/embarklabs/embark.git
synced 2025-01-09 21:35:58 +00:00
b49839afdc
The webpack process took quite a while to run, and there were no updates in the console while running. This PR adds a spinner (when there is no dashboard) and status updates every 5 seconds. When there is a dashboard, the updates are added to a new line. After (with dashboard): ![with dashboard](https://i.imgur.com/zVJH5U4.png) After (`—nodashboard`): ![no dashboard](http://g.recordit.co/2zRNLt51jU.gif) Convert LongRunningProcessTimer to TypeScript PR feedback and consistency changes Changed the constructor signature to accept an options object instead of individual optional parameters, for readability. Changed library_manager to use the spinner when not using the dashboard, for consistency’s sake. Additionally increased the update time for the library manager from 750ms to 1s. Fix lint errors Added `"variable-name": ["allow-leading-underscore”]` to `tslint.json` due to a lack of the ability to prefix backing variables with underscore. This is an [ongoing discussion](https://github.com/palantir/tslint/issues/1489), and something the community thinks should be implemented, as it the preferred way to use a property with backing variable in TypeScript.
18 lines
379 B
JSON
18 lines
379 B
JSON
{
|
|
"defaultSeverity": "error",
|
|
"extends": [
|
|
"tslint:recommended"
|
|
],
|
|
"jsRules": {},
|
|
"rules": {
|
|
"max-line-length": [true, 200],
|
|
"interface-name": [true, "never-prefix"],
|
|
"member-ordering": [false],
|
|
"no-var-requires": false,
|
|
"no-empty": false,
|
|
"no-console": false,
|
|
"variable-name": ["allow-leading-underscore"]
|
|
},
|
|
"rulesDirectory": []
|
|
}
|