mirror of
https://github.com/embarklabs/embark.git
synced 2025-02-05 18:33:26 +00:00
3693ebd90d
Many packages in the monorepo did not specify all of their dependencies; they
were effectively relying on resolution in the monorepo's root
`node_modules`. In a production release of `embark` and `embark[js]-*` packages
this can lead to broken packages.
To fix the problem currently and to help prevent it from happening again, make
use of the `eslint-plugin-import` package's `import/no-extraneous-dependencies`
and `import/no-unresolved` rules. In the root `tslint.json` set
`"no-implicit-dependencies": true`, wich is the tslint equivalent of
`import/no-extraneous-dependencies`; there is no tslint equivalent for
`import/no-unresolved`, but we will eventually replace tslint with an eslint
configuration that checks both `.js` and `.ts` files.
For `import/no-unresolved` to work in our monorepo setup, in most packages add
an `index.js` that has:
```js
module.exports = require('./dist'); // or './dist/lib' in some cases
```
And point `"main"` in `package.json` to `"./index.js"`. Despite what's
indicated in npm's documentation for `package.json`, it's also necessary to add
`"index.js"` to the `"files"` array.
Make sure that all `.js` files that can and should be linted are in fact
linted. For example, files in `packages/embark/src/cmd/` weren't being linted
and many test suites weren't being linted.
Bump all relevant packages to `eslint@6.8.0`.
Fix all linter errors that arose after these changes.
Implement a `check-yarn-lock` script that's run as part of `"ci:full"` and
`"qa:full"`, and can manually be invoked via `yarn cylock` in the root of the
monorepo. The script exits with error if any specifiers are found in
`yarn.lock` for `embark[js][-*]` and/or `@embarklabs/*` (with a few exceptions,
cf. `scripts/check-yarn-lock.js`).
29 lines
759 B
JSON
29 lines
759 B
JSON
{
|
|
"name": "embark-inside-monorepo",
|
|
"private": true,
|
|
"version": "5.1.0",
|
|
"author": "Michael Bradley <michaelsbradleyjr@gmail.com> (https://github.com/michaelsbradleyjr/)",
|
|
"description": "If a package from the monorepo can resolve this package then the first package is inside the monorepo",
|
|
"license": "MIT",
|
|
"main": "./src/index.js",
|
|
"scripts": {
|
|
"ci": "npm run qa",
|
|
"clean": "npm run reset",
|
|
"lint": "eslint src/",
|
|
"qa": "npm-run-all lint",
|
|
"reset": "npx rimraf embark-*.tgz package"
|
|
},
|
|
"eslintConfig": {
|
|
"extends": "../../../.eslintrc.json"
|
|
},
|
|
"devDependencies": {
|
|
"eslint": "6.8.0",
|
|
"rimraf": "3.0.0"
|
|
},
|
|
"engines": {
|
|
"node": ">=10.17.0",
|
|
"npm": ">=6.11.3",
|
|
"yarn": ">=1.19.1"
|
|
}
|
|
}
|