mirror of https://github.com/embarklabs/embark.git
030fb4acc6
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web3 v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the resolved return value's type using TypeScript's `as` operator. |
||
|---|---|---|
| .. | ||
| accounts-manager | ||
| basic-pipeline | ||
| coverage | ||
| debugger | ||
| deploy-tracker | ||
| ens | ||
| ethereum-blockchain-client | ||
| ganache | ||
| geth | ||
| graph | ||
| ipfs | ||
| mocha-tests | ||
| nethermind | ||
| parity | ||
| plugin-cmd | ||
| profiler | ||
| rpc-manager | ||
| scaffolding | ||
| snark | ||
| solc | ||
| solidity | ||
| solidity-tests | ||
| specialconfigs | ||
| suggestions | ||
| swarm | ||
| transaction-logger | ||
| transaction-tracker | ||
| vyper | ||
| web3 | ||
| whisper-geth | ||
| whisper-parity | ||
| .gitignore | ||