Commit Graph

14 Commits

Author SHA1 Message Date
emizzle ffe0157543 removed unneeded comment 2018-06-15 17:06:59 -04:00
emizzle a100dd4260 Requested PR fixes
Added catch to live-plugin-manager install promise running in child process

Removed some `else`'s ;)

Only showing solc downloading spinner when `--nodashboard` option is used.

When installing package in main process and simultaneous downloads fail, all callbacks called with error.

Updated logging in npmTimer.
2018-06-15 17:06:59 -04:00
emizzle eedcdc77a7 Solc loading issue now fully resolved
Added better error checking for solidity compilation errors

Extracted timer functionality for downloading packages so it works across the main process and child processes.

Npm class is instantiated only once and reused for event commands.

Npm class can handle concurrent requests for the same package and callback the installation result for each request.
2018-06-15 17:02:53 -04:00
emizzle 62f3b85bc4 Finally fixed the solc loading issue.
Moved the instantiation of the live-plugin-manager in to the child solc process. This allowed us to use the live-plugin-manager to require the installed solc file.

If the module is the same version as used by embark, the module is still loading using the normal require (from node_modules), as before.
2018-06-15 16:54:08 -04:00
Iuri Matias 19aa117503 update references to package 2018-06-13 09:40:19 -04:00
emizzle 7e2f5624ba Increased time before reporting of library download duration goes red to 4 seconds.
Incrased travis build version to node 8, as embark only supports 8.10, and also perf_hooks requires 8.5
2018-06-06 12:04:30 +10:00
emizzle bbaf1676fb Updates console to inform user of an ongoing package download.
Console message turns red after 1 second.
2018-06-06 11:39:13 +10:00
Iuri Matias 0b70f32bb9 initial work for i18n 2018-05-10 15:01:34 -04:00
Iuri Matias ade2ad1a67 comply with linter 2018-04-20 19:59:47 -04:00
Iuri Matias 41f04234d0 clean up 2018-04-20 19:52:51 -04:00
Iuri Matias cf02a10656 use web3 naming instead of web3.js; check if package already exists 2018-04-20 19:45:57 -04:00
Iuri Matias 1b6d747dbd fixing package management test 2018-04-20 17:17:49 -04:00
Iuri Matias df765ed056 fix version issue causing a contract to be undefined due to a pipeline error 2018-03-22 15:36:20 -04:00
Iuri Matias 1c38f3fb89 move lib 2017-12-30 18:25:59 -05:00