Anthony Laibe
7e12f80eda
Address PR feedback
2018-10-22 19:25:16 +02:00
Anthony Laibe
850a80c90c
ENS config use the actual network ID
...
Instead of relying on the name of network.
Fetch the real network id and configure ENS
based on that value
2018-10-22 19:25:16 +02:00
Anthony Laibe
e593ba5e42
Remove unneeded logger.error
...
The pipeline and the deployer/compiler display
the error themselves
2018-10-22 19:25:15 +02:00
Iuri Matias
1fd3cd268f
Merge pull request #907 from embark-framework/bug_fix/upload-cmd-ens-setprovider-missing
...
upload command should unconditionally start the "namingSystem" service
2018-09-26 09:20:46 -04:00
Michael Bradley, Jr
79af0c0186
`embark upload` unconditionally starts the "namingSystem" service
2018-09-25 11:09:38 -05:00
Michael Bradley, Jr
0e5989bf40
rev --template
...
if option is used, param must be supplied
"GitHub repository" -> "git host" in help output
2018-09-24 17:46:29 -05:00
Iuri Matias
9ac3f56c98
update template option message
2018-09-21 18:18:21 -04:00
Iuri Matias
af823f98b6
clarify template option; hide ens option; update typo suggestion list
2018-09-21 17:51:33 -04:00
Anthony Laibe
09de3201a1
Set default account back
2018-09-20 11:49:05 +01:00
Iuri Matias
501ddd610e
Merge pull request #869 from embark-framework/cli/coverage-only-with-vm
...
--coverage requires --node be "vm"
2018-09-19 11:58:39 -04:00
Michael Bradley, Jr
a6231851b0
consistent quotes
2018-09-18 15:06:27 -05:00
Michael Bradley, Jr
fc68e9be3c
rev --gasDetails help output
2018-09-18 15:06:04 -05:00
Michael Bradley, Jr
b2c7ef37b7
rev --node help output
2018-09-18 15:06:04 -05:00
Michael Bradley, Jr
dbac72ea7d
--coverage option only support "vm" node
2018-09-18 15:05:52 -05:00
Michael Bradley, Jr
3806dd6cd1
`embark reset` should remove a dapp's coverage/ subdir
2018-09-18 14:22:47 -05:00
Michael Bradley, Jr
1f652a7672
deploy -> deployment
2018-09-18 12:55:37 -05:00
Iuri Matias
904c716d89
Merge pull request #856 from embark-framework/features/config-browser-open
...
cli and config options for browser auto-open
2018-09-18 13:11:55 -04:00
Michael Bradley, Jr
a49d8eafa1
clarify re: GitHub
2018-09-18 10:24:40 -05:00
Michael Bradley, Jr
19dc3a1d13
match wording on docs site
2018-09-17 18:50:47 -05:00
Michael Bradley, Jr
c360975e8f
webServer svc doesn't need to handle cli opts (handled in core/config)
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
2b5268dc84
test null when populating webserver config derived from cli
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
638fb4ee27
allow config to determine webserver enabled if no --noserver cli opt
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
a966ecb131
for --host,--port coerce falsy and bool to null
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
64027a5ee4
--nobrowser cli option
2018-09-17 17:59:52 -05:00
Michael Bradley, Jr
6e60566b27
add line break between error message and help output
2018-09-14 20:44:22 -05:00
emizzle
6e444aaf65
simplied the valid option check to pure regex
2018-09-15 11:38:48 +10:00
emizzle
269d544ab3
show option usage help with invalid `—node` option and simplied the valid option check to pure regex
2018-09-15 11:36:24 +10:00
Michael Bradley, Jr
203039763d
`node` won't ever be falsy owing to `|| 'vm'`
2018-09-14 20:25:22 -05:00
Michael Bradley, Jr
f790ecdcbb
be more explicit about setting the default option value to 'vm'
2018-09-14 20:15:48 -05:00
Michael Bradley, Jr
ac930d0be0
report error and exit if --node option value is not valid
2018-09-14 19:58:23 -05:00
Iuri Matias
9f1cb71117
Merge pull request #837 from embark-framework/eject_msg
...
modify eject msg
2018-09-14 18:20:42 -04:00
Iuri Matias
3c167b197c
Merge pull request #823 from embark-framework/features/embark-help-addition
...
`embark test —node` help, plus fix for vm option
2018-09-14 18:13:07 -04:00
Iuri Matias
9b2fa9402b
Merge pull request #822 from embark-framework/bugfix/circular-json
...
Fix circular JSON and swarm api require
2018-09-14 18:11:34 -04:00
emizzle
7658818571
remove custom option validation
...
Was trying to get a bit too fancy and show an error message if the user didn’t provide a valid value. Instead, if they use `—node` and the value is not a valid option, `vm` will be the default.
2018-09-14 15:23:38 +10:00
Iuri Matias
6d54a40bb2
Merge pull request #827 from embark-framework/bug_fix/prepend-embark-plugin-install
...
Prepend "embark-" to plugin names and little fixes
2018-09-13 19:46:49 -04:00
Iuri Matias
98b999618b
modify eject msg
2018-09-13 16:43:43 -04:00
Jonathan Rainville
43a9640297
add option to generate the coverage
2018-09-13 14:30:15 -04:00
Jonathan Rainville
ddb1872db5
fix undefined message in console
2018-09-13 10:28:03 -04:00
emizzle
60703b86c5
`embark test —node` help, plus fix for vm option
...
Add better help info for `embark test —node`.
Fixed issue with `embark test —node vm` where the `vm` was attempted to be parsed as a URL instead of running the simulator.
2018-09-13 20:34:58 +10:00
Anthony Laibe
c22901ab95
Fix circular JSON and swarm api require
2018-09-13 11:21:17 +01:00
Anthony Laibe
1b242baefd
No webserver and no ipc server on console
2018-09-13 09:19:57 +01:00
Iuri Matias
f270002c81
Merge pull request #819 from embark-framework/features/contarct-option-no-ipfs
...
Do not start storage and code_generator on --contracts
2018-09-12 18:44:33 -04:00
Iuri Matias
a912cdd464
Merge pull request #818 from embark-framework/bug_fix/dep-check-on-wrong-cmd
...
Only check dependencies on Dapp commands
2018-09-12 18:43:00 -04:00
Iuri Matias
dfe49291be
Merge pull request #797 from subramanianv/pluginCmd
...
Plugin cmd
2018-09-12 17:57:18 -04:00
Jonathan Rainville
afaf29d403
do not start storage and code_generator on --contracts
2018-09-12 11:10:39 -04:00
Jonathan Rainville
4dcaa529f9
move check dependencies to specific commands
2018-09-12 10:57:09 -04:00
Michael Bradley, Jr
c662ab362b
eject-webpack cmd should report error and exit if run outside DApp
2018-09-11 19:37:06 -05:00
Subramanian Venkatesan
fe0bbc3559
changes from the code review
2018-09-10 22:38:17 +05:30
Subramanian Venkatesan
74f0d05ca0
Plugin Command
2018-09-09 23:07:55 +05:30
Jonathan Rainville
542462faed
check deps before launching
2018-09-07 12:37:18 -04:00
Iuri Matias
10035fe46b
Merge pull request #786 from embark-framework/bug_fix/upload-simple
...
Fix uploading a simple app
2018-09-05 18:23:27 -04:00
Iuri Matias
ebf3d9ba7e
Merge pull request #783 from embark-framework/bugfix/command-description-testrpc
...
Remove testrpc option
2018-09-05 18:21:44 -04:00
Iuri Matias
6f7c999091
Merge pull request #784 from embark-framework/bugfix/typo
...
Fix typo
2018-09-05 18:21:30 -04:00
Jonathan Rainville
74e9974c00
exit with 1
2018-09-05 11:48:14 -04:00
Jonathan Rainville
047286b46d
skip webpack if no js files
2018-09-05 11:38:09 -04:00
Anthony Laibe
ad118f42c0
Fix typo
2018-09-05 14:29:26 +01:00
Anthony Laibe
caeb0c86b4
Remove testrpc option
2018-09-05 14:12:26 +01:00
Anthony Laibe
c92f6f8865
Fix dynamic IPC
2018-09-05 10:40:37 +01:00
Iuri Matias
a1c2d7e77a
Merge pull request #756 from embark-framework/feature/console-ipc-server-client
...
Console can be a client or server ipc
2018-08-31 07:58:55 -04:00
Anthony Laibe
e0f73c7d22
Make console a module
2018-08-31 09:36:50 +01:00
Anthony Laibe
59e82d5fc6
Console can be a client or server ipc
2018-08-30 15:45:01 +01:00
Anthony Laibe
31cb79bf5b
PR feedback
2018-08-30 10:41:13 +01:00
Anthony Laibe
307b7dc8e7
EmbarkJS available
2018-08-30 10:04:58 +01:00
Michael Bradley, Jr
4c63c5adef
--pipeline option (default: production) for `embark upload` command
2018-08-28 15:44:13 -05:00
Michael Bradley, Jr
4234324640
need to require('path')
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
1e97a6478b
prefer path.delimiter
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
d14ee86c32
if dapp has a webpack.config.js, make a backup copy and proceed
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
e0fda460ba
--pipeline option for `embark console`, defaults to 'development'
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
2c54349c33
rev comment re: NODE_PATH
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
ba98f76a10
no separator if proces.env.NODE_PATH is falsy
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
d4f8dd6608
rev comment re: NODE_PATH
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
e1fb746aa7
relocate webpack.config.js under lib/pipeline/
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
b7fd109237
setup env vars w/in cmd.js
2018-08-24 15:04:16 -05:00
Michael Bradley, Jr
2670476d5e
`embark eject-webpack` command
2018-08-24 15:04:15 -05:00
Michael Bradley, Jr
51ac4ddee8
`embark reset` should cleanup dapp's node_modules/.cache
2018-08-24 15:04:15 -05:00
Michael Bradley, Jr
b41f5a397d
--pipeline option for `ebmark build|run` to spec webpack config name
2018-08-24 15:04:15 -05:00
Anthony Laibe
de57e48cff
Isolate the code runner
2018-08-24 14:05:19 +01:00
Jonathan Rainville
3f561f5257
use node option for tests
2018-08-22 16:46:39 -04:00
Jonathan Rainville
70d71b190c
remove chdir override and set PWD from the get go
2018-08-21 16:11:07 -04:00
Jonathan Rainville
6589101deb
fix sed issue in windows
2018-08-21 16:11:07 -04:00
Anthony Laibe
a7b0cea09b
Console via IPC do not run on deploy
2018-08-21 16:10:22 -04:00
Anthony Laibe
a59cc29d39
IPC works with errors, console print errors
2018-08-21 16:10:22 -04:00
Iuri Matias
8dcdc7fa38
add help cmd; fix locale
2018-08-21 16:10:22 -04:00
Anthony Laibe
eeb8fa752d
Add link to documentation
2018-08-21 16:09:48 -04:00
Anthony Laibe
774a14c850
Support old and new console plugin with a warning
2018-08-21 16:09:48 -04:00
Anthony Laibe
0924f2dfd0
Apply feedback
2018-08-21 16:09:48 -04:00
Anthony Laibe
27933774a9
Console command connect to ipc
2018-08-21 16:09:48 -04:00
Jonathan Rainville
324e09eb35
hotfixx blockchain command requires
2018-08-21 16:09:13 -04:00
Iuri Matias
33666bd030
rename to cmd
2018-08-21 16:09:13 -04:00