embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
4,103 Commits 171 Branches 184 Tags 104 MiB
Commit Graph

2610 Commits

Author SHA1 Message Date
emizzle 86480440b1
Updated online/offline event checks so they are run during initialisation. 
Changed the online event to `once` and set it to be bound every time the node goes offline.

The above changes handle the case where:
1) `embark run` runs and starts geth.
2) geth is killed manually
3) `embark blockchain` is run in separate process to restart geth
4) the `embark run` process detects this change and restarts the web3 provider and recompiles/deploys/builds

Every time `embark blochain` is restarted, an error is appended and all are emitted from the `eth-block-tracker`. This is a bug but can't figure out where it originates. The downside is that if, for example, `embark blockchain` is restarted 4 times, there will be 4 errors emitted from the `eth-block-tracker`. Because of this, errors emitted from `eth-block-tracker` have been reduced to trace to avoid clogging the logs.
 2018-10-23 10:03:03 +02:00
emizzle 80e323bdd3
Handle geth process exit via crash/kill and also via killing `embark blockchain` 
First case - run `embark run` which starts a blockchain node, then manually kill the `geth` process. Would throw `{ [Error: connect ECONNREFUSED 127.0.0.1:8543] message: 'connect ECONNREFUSED 127.0.0.1:8543', code: -32603 }` error and ruins the dashboard.

Second case, 1) run `embark blockchain` 2) run `embark run` 3) kill `embark blockchain` throws the error `{ [Error: connect ECONNREFUSED 127.0.0.1:8543] message: 'connect ECONNREFUSED 127.0.0.1:8543', code: -32603 }` and ruins the dashboard.

The first case was solved by having the child blockchain process that spawns geth listen for geth exit, then kill itself.

The second case required updating of `eth-block-tracker` to v4.0.1 inside of the `embark-web3-provider-engine`. v4.0.1 was a major version update and introduced breaking changes. Those changes were handled inside of `embark-web3-provider-engine`, covered in **blocker** PR https://github.com/jrainville/provider-engine/pull/1.
 2018-10-23 10:03:03 +02:00
Richard Ramos 23eee6e19b
Fix for skip-undeployed is not specified 2018-10-23 10:03:03 +02:00
Jonathan Rainville bab0b71831
fix tests using new dependencies 2018-10-23 10:01:55 +02:00
Jonathan Rainville 38f32804f9
make groups of dependencyCount to do async by group 2018-10-23 10:01:55 +02:00
VoR0220 f2feff597f
callback fixes and get rid of resolver interface 
Signed-off-by: VoR0220 <catalanor0220@gmail.com>
 2018-10-23 10:01:54 +02:00
VoR0220 592e4db762
more unnecessary contracts gotten rid of, and fixes made to Embarkjs file 
Signed-off-by: VoR0220 <catalanor0220@gmail.com>
 2018-10-23 10:01:54 +02:00
VoR0220 ac6c741a15
get rid of unnecessary contracts for this iteration 
Signed-off-by: VoR0220 <catalanor0220@gmail.com>
 2018-10-23 10:01:54 +02:00
VoR0220 6efb5eee9d
add ens contracts 
Signed-off-by: VoR0220 <catalanor0220@gmail.com>
 2018-10-23 10:00:30 +02:00
Iuri Matias 31a3fbef66
fixes due to bad rebase 2018-10-23 10:00:30 +02:00
Iuri Matias b3ccaa3b8a
fixes due to bad rebase 2018-10-23 09:57:47 +02:00
Iuri Matias f873a26caf
fixes due to bad rebase 2018-10-23 09:57:47 +02:00
Iuri Matias f02de020de
fixes due to bad rebase 2018-10-23 09:57:47 +02:00
Richard Ramos 94eca4751a
Addid basic templating to start building UI from here 2018-10-23 09:57:16 +02:00
Richard Ramos 8861588726
Adding base command logic for scaffolding generation 2018-10-23 09:57:16 +02:00
Anthony Laibe 1800f506b1
Add IPNS demo 2018-10-23 09:57:16 +02:00
Iuri Matias 663dac6009
move processes into core 2018-10-23 09:56:18 +02:00
Iuri Matias 43448f62ef
move blockchain connection code to its own module 2018-10-23 09:56:18 +02:00
Iuri Matias 0585c5b3eb
move blockchain process to own module 2018-10-23 09:55:10 +02:00
Iuri Matias db7f3d39d3
first stab at refactor blockchain launcher 2018-10-23 09:55:10 +02:00
Jonathan Rainville d5b224eee7
only enabble register in dev 2018-10-23 09:53:47 +02:00
Jonathan Rainville e95efbfc54
small cleanups 2018-10-23 09:53:47 +02:00
Jonathan Rainville 5a842c9b70
if no register config, dont register anything 2018-10-23 09:53:26 +02:00
Anthony Laibe 9fe14a0790
Remove code dependencies to underscore 2018-10-23 09:52:57 +02:00
Jonathan Rainville 0bbc1f89b6
remove provider-engine as it has been creating lots of issues 2018-10-23 09:52:57 +02:00
Jonathan Rainville 7b5e88a6a9
wip fixes 2018-10-23 09:52:40 +02:00
Jonathan Rainville bc837848d2
conflict in package json 2018-10-23 09:51:58 +02:00
emizzle 90be6125db
Removed p-iteration from embark altogether. 
Replaced usage in storage module (on dapp side) with async.js `detectSeries`
 2018-10-23 09:51:58 +02:00
Iuri Matias 4e881cd291
rebase fixes 2018-10-23 09:51:58 +02:00
Iuri Matias 8ed808a101
fixes due to bad rebase 2018-10-23 09:47:41 +02:00
Iuri Matias 95df68e67c
fixes due to bad rebase 2018-10-23 09:46:40 +02:00
Iuri Matias 6fac1f297d
fixes due to bad rebase 2018-10-23 09:42:59 +02:00
Iuri Matias c4ea6abc4b
fixes due to bad rebase 2018-10-23 09:42:59 +02:00
Iuri Matias 2e3102444d
fixes due to bad rebase 2018-10-23 09:42:58 +02:00
Richard Ramos fdb2d4aed3
Changes based on code review 
- Style changes for not requiring "else" in handlebar helpers
- Changed build to async
 2018-10-23 09:42:10 +02:00
Richard Ramos 2c18caf481
Fixing template 2018-10-23 09:42:10 +02:00
Richard Ramos 04ad83aee3
Reorganizing template 2018-10-23 09:42:10 +02:00
Richard Ramos 6dfd31639a
Simplified error handling 2018-10-23 09:42:10 +02:00
Richard Ramos 995b067f63
Uncommented error throwing 2018-10-23 09:42:10 +02:00
Richard Ramos 6f249df4bf
Fixed plugin loading logic 2018-10-23 09:42:09 +02:00
Richard Ramos 435b18d074
Added payable functionality 2018-10-23 09:42:09 +02:00
Richard Ramos c562128365
Disabling button while loading 2018-10-23 09:42:09 +02:00
Richard Ramos d19bcdcbf9
Base logic for invoking send functions and showin results 2018-10-23 09:42:09 +02:00
Richard Ramos 10c5b64b1c
Alert for error invoking functions 2018-10-23 09:42:09 +02:00
Richard Ramos e7d435f03d
Handling boolean parameters 2018-10-23 09:42:08 +02:00
Richard Ramos d80d16f4ca
Form generation for view/constant/pure functions 2018-10-23 09:42:08 +02:00
Richard Ramos 8acf136c01
Importing contract and bootstrap css 2018-10-23 09:42:08 +02:00
Richard Ramos c4961d69b6
JS generation + embark.json configuration update 2018-10-23 09:42:08 +02:00
Richard Ramos d1dd890407
Addid basic templating to start building UI from here 2018-10-23 09:42:08 +02:00
Richard Ramos 0eaafb77f1
Adding base command logic for scaffolding generation 2018-10-23 09:42:08 +02:00
Iuri Matias 6d0f4b67ae
move processes into core 2018-10-23 09:41:26 +02:00
Iuri Matias b8cbee460b
move blockchain connection code to its own module 2018-10-23 09:41:26 +02:00
Iuri Matias a0f209745f
move accountParser to utils 2018-10-23 09:39:03 +02:00
Iuri Matias 8136759bbb
refactor blockchain check 2018-10-23 09:39:03 +02:00
Iuri Matias 94422cd893
re-add events 2018-10-23 09:39:03 +02:00
Iuri Matias 91cc554978
cleanup 2018-10-23 09:39:03 +02:00
Iuri Matias 14ac24d657
move process files into processes folder 2018-10-23 09:39:02 +02:00
Iuri Matias c8fc515c03
move blockchain process related files into blockchain module 2018-10-23 09:39:02 +02:00
Iuri Matias c5d9a759af
move blockchain process to own module 2018-10-23 09:39:02 +02:00
Iuri Matias 4406dddf1e
first stab at refactor blockchain launcher 2018-10-23 09:39:02 +02:00
Michael Bradley, Jr d4940a339a
proxy -- canonicalHost, defaultHost 2018-10-23 09:37:24 +02:00
Michael Bradley, Jr fc27e710fc
blockchain -- defaultHost, dockerHostSwap 2018-10-23 09:37:24 +02:00
Michael Bradley, Jr a29d78cc5a
simulator -- defaultHost, dockerHostSwap 2018-10-23 09:37:24 +02:00
Jonathan Rainville 931f56db7d
only enabble register in dev 2018-10-23 09:37:24 +02:00
Jonathan Rainville 5488961a1e
small cleanups 2018-10-23 09:37:06 +02:00
Jonathan Rainville 81557258ce
pre-dploy using the same function as register 2018-10-23 09:07:19 +02:00
Jonathan Rainville 2cd11715bb
if no register config, dont register anything 2018-10-23 09:05:00 +02:00
Anthony Laibe 424d375f87
Remove code dependencies to underscore 2018-10-23 09:03:32 +02:00
Michael Bradley, Jr 0629f757a9
rm commented code and extra whitespace 2018-10-23 09:03:31 +02:00
Jonathan Rainville 3dcee19002
fix the indexOf instead by simulating what solc does 2018-10-23 09:03:31 +02:00
Jonathan Rainville 31162882c7
fix duplicate dependencies and warn correctly for length 2018-10-23 09:03:31 +02:00
Michael Bradley, Jr 15159e4ef3
Embark's own ganache-cli will always be found 2018-10-23 09:03:31 +02:00
Andre Medeiros 00410b7057
Fix failing test on blockchain 2018-10-23 09:03:30 +02:00
Jonathan Rainville 7e16691aa6
fix webserver errors 2018-10-23 09:02:41 +02:00
Iuri Matias 62c46063b3
refactor install template code 2018-10-23 09:02:41 +02:00
Iuri Matias aebc2a9b28
add support to download a template 2018-10-23 09:02:40 +02:00
Jonathan Rainville 3ca70d6e21
remove provider-engine as it has been creating lots of issues 2018-10-23 09:02:40 +02:00
Jonathan Rainville da82c2eba2
wip fixes 2018-10-23 09:02:15 +02:00
Jonathan Rainville 8572019957
fix when using mining script 2018-10-23 09:01:14 +02:00
Jonathan Rainville 91a7cc1a44
only put isDev when specifically set 2018-10-23 09:01:14 +02:00
Jonathan Rainville cb80b984d0
revert caca code 2018-10-23 09:01:14 +02:00
Jonathan Rainville 966252be97
conflict in package json 2018-10-23 09:01:13 +02:00
emizzle 3a145d4204
Removed p-iteration from embark altogether. 
Replaced usage in storage module (on dapp side) with async.js `detectSeries`
 2018-10-23 09:01:13 +02:00
emizzle c83b6dde60
Handle geth process exit via crash/kill and also via killing `embark blockchain` 
First case - run `embark run` which starts a blockchain node, then manually kill the `geth` process. Would throw `{ [Error: connect ECONNREFUSED 127.0.0.1:8543] message: 'connect ECONNREFUSED 127.0.0.1:8543', code: -32603 }` error and ruins the dashboard.

Second case, 1) run `embark blockchain` 2) run `embark run` 3) kill `embark blockchain` throws the error `{ [Error: connect ECONNREFUSED 127.0.0.1:8543] message: 'connect ECONNREFUSED 127.0.0.1:8543', code: -32603 }` and ruins the dashboard.

The first case was solved by having the child blockchain process that spawns geth listen for geth exit, then kill itself.

The second case required updating of `eth-block-tracker` to v4.0.1 inside of the `embark-web3-provider-engine`. v4.0.1 was a major version update and introduced breaking changes. Those changes were handled inside of `embark-web3-provider-engine`, covered in **blocker** PR https://github.com/jrainville/provider-engine/pull/1.
 2018-10-23 09:01:13 +02:00
Jonathan Rainville 8db33705c2
hotfix: rename event to blockchain:ready 2018-10-22 20:50:58 +02:00
Jonathan Rainville b6d89d9001
hotfix: fix empty assets array 2018-10-22 20:26:01 +02:00
emizzle 559c7152f7
Return early when error 2018-10-22 19:54:50 +02:00
emizzle 178115de18
Removed `mineWhenNeeded` condition 
Removed a condition that detects if `mineWhenNeeded === true`. While reaslistically, the `defaultAccount` will only be populated when `mineWhenNeeded` is set, there is no need to check for this when falling back to the blockchain account.
 2018-10-22 19:54:50 +02:00
emizzle 294e14446f
Auto set swarm account to account controlled by the node 
When there is no account/password specified for swarm, there was an error shown in the logs (asking for address/password), and the swarm process would quit.

This PR changes the behaviour so that if a swarm address/password are not specified in the config, it attempts to use the blockchain address/password specified in `config/blockchain > account`. If `config/blockchain > account > address` doesn’t exist, the first account controlled by the node is used (provided by `web3.eth.getAccounts`, along with the password from `config/blockchain > account > password`.
 2018-10-22 19:54:50 +02:00
emizzle 3437f80a89
Return early if no modified assets 2018-10-22 19:54:50 +02:00
Jonathan Rainville 5b1a226885
Update null check for `modifiedAssets` array. 
Co-Authored-By: emizzle <ericmastro@status.im>
 2018-10-22 19:54:49 +02:00
emizzle 7c9d90090a
Replaced async.queue with async.cargo 
Cargo in fact, bundles up subsequent tasks in to an array, so any tasks that are not immediately run get bundled in to another run later. This helps when lots of changes have been made in a short period of time.
 2018-10-22 19:54:49 +02:00
emizzle e788b7d3d4
Reduce async.queue concurrency to 3 
Due to a process being spawned for every pipeline run, concurrency should remain around 3 to keep number of child processes from running away and allowing the CPU to stay on top.
 2018-10-22 19:54:49 +02:00
Michael Bradley, Jr 6eae7a9a31
use a customized require/.resolve instead of relying on NODE_PATH 
# Conflicts:
#	cmd/cmd.js
 2018-10-22 19:54:49 +02:00
emizzle 64fdc691c4
Clean up 2018-10-22 19:54:49 +02:00
emizzle 91e5e9c990
Do not run webpack for file changes that do not need webpack 
For file changes that do not require a webpack run, ie HTML, the assets will still be copied to the output directory, but webpack will not run (as it’s too slow).
 2018-10-22 19:54:48 +02:00
emizzle 7e75b1eee7
Add support for ES6 plugins 2018-10-22 19:54:48 +02:00
emizzle 2d19d12e39
Support for embark-status plugin 
Added request to update cors from a plugin (affects blockchain client and storage client).
 2018-10-22 19:54:48 +02:00
hodlbank 870d9a814a
[f] Fixes #965 - "Console doesnt have contract objects for contracts with pre-defined addresses configured". 
[f] Fix for sometimes incorrect empty code detection in contract_deployer.js ("0x" vs "0x0").
 2018-10-22 19:54:48 +02:00
Jonathan Rainville 985358b088
fix web3 being reseted every test and fix ens failing on web3 reset 2018-10-22 19:54:48 +02:00
Jonathan Rainville ce3f9bdf25
fix a couple of bugs caused by bounties 2018-10-22 19:54:48 +02:00
Jonathan Rainville 7a70f5df26
use constants instead of magic numbers 2018-10-22 19:54:47 +02:00
Jonathan Rainville fe0b84349a
update noserver and nobrowser and fix noserver 2018-10-22 19:54:47 +02:00
Jonathan Rainville 75d9998c57
refactor to not use the blockchain_connector directly 2018-10-22 19:54:47 +02:00
Jonathan Rainville e450c0484a
fix error in solc-tests 2018-10-22 19:54:46 +02:00
Jonathan Rainville c6aa19a772
use this instead of self 2018-10-22 19:54:46 +02:00
Jonathan Rainville ac9dbdd1d6
conflict in test 2018-10-22 19:54:46 +02:00
Jonathan Rainville ac155ddb86
conflict in specialconfigs 2018-10-22 19:54:46 +02:00
Jonathan Rainville f4d7636b7a
make code coverage work with refactored tests 2018-10-22 19:54:45 +02:00
Jonathan Rainville 7516bad619
use blockchain_connector's provider for nodes 2018-10-22 19:54:45 +02:00
Jonathan Rainville 5a5485d447
get rid of dependency on web3 2018-10-22 19:54:45 +02:00
Jonathan Rainville ddc8b36329
make tests work by using events 2018-10-22 19:54:45 +02:00
Jonathan Rainville ca3aea7923
BROKEN: solc doesnt load 2018-10-22 19:54:45 +02:00
Jonathan Rainville 3c0bcb18b8
rename events to use a tests prefix 2018-10-22 19:54:44 +02:00
Jonathan Rainville e8574f33eb
conflict in run_tests 2018-10-22 19:54:44 +02:00
Jonathan Rainville e6cad1675a
move test files to a module folder 2018-10-22 19:54:44 +02:00
Andre Medeiros 7104c18b83
Only disable optimizations with coverage. 
This means that any test runs without coverage will run optimized
Solidity code instead.
 2018-10-22 19:54:44 +02:00
Anthony Laibe 27973461b1
In case of ws, use the connected attribute 
Instead of relying on non reliable source, directly
check the ws status
 2018-10-22 19:54:44 +02:00
Cryptomental 47dcb1552c
console, dashboard: Add persistent, automatically loaded history. 
Add persistent automatically loaded history file for repl console
and Embark dashboard.

Default location of the history file is stored in DEFAULT_CMD_HISTORY_PATH
pointing to DAPP_PATH/.embark/cmd_history.

The history is automatically saved and loaded on startup.

test/console: Pass Embark object to constructor.

Update console test to pass Embark object to constructor.

Refs: https://github.com/embark-framework/embark/issues/939
 2018-10-22 19:54:43 +02:00
emizzle 5fe746df51
Add message warning user a password is needed to unlock 
When `mineWhenNeeded` is true (occurs in zero-config) and an account on the node exists, a password is required to be specified `config/blockchain.js > account > password` so that the existing account can be unlocked by geth (the `—unlock` cli option).
 2018-10-22 19:54:43 +02:00
Dan Lipert 898ecfe293
Accept standard Ether units and update/add tests 2018-10-22 19:54:43 +02:00
Michael Bradley, Jr 4812a0d1a2
additional warning re: potential version incompatibility 2018-10-22 19:53:50 +02:00
Subramanian Venkatesan f686fec74a
ens resolve 2018-10-22 19:53:50 +02:00
Michael Bradley, Jr 0f6e84bca3
return in the catch branch so the control flow is more clear 2018-10-22 19:53:49 +02:00
Michael Bradley, Jr b9e592ae2e
color retry message yellow 2018-10-22 19:53:49 +02:00
Michael Bradley, Jr 1f47b163e4
auto-retry download with master branch 
a fallback download of the master branch is attempted only for unqualified
template names
 2018-10-22 19:53:49 +02:00
Giuseppe Bertone 81e798c89c
Add support for Parity 
Addons
 - New chain initialization and genesis management
 - Option to choose client to use
 - Option to "ping forever" for Geth
 - Creation and unlock of accounts at client's start
 - Utility to fund accounts with ethers
 - Miner settings inside the ethereum client
 - Workaround to CORS problem: origin is now http://embark
 - Several double callback's checks

Updates
 - Boilerplate, templates, configuration files and demo stuff
 - Messages and i18n strings
 - Tests

Fixes
 - Geth client now uses miner.gastarget instead of the deprecated targetGasLimit
 - Workaround for shh_version with Parity

Reworks of other PRs into the new code
 - Included delayed proxy
 - Send ready only when the proxy is started
 - Start HTTP and WS proxies individually
 - Async setupProxy
 - Fixed datadir for GethMiner
 2018-10-22 19:53:49 +02:00
Michael Bradley, Jr cc08a16ae3
calc a <major>.<minor> branch for unqualified template names 
doesn't calc a branch if a url/shortcut is supplied that hostedGitInfo knows
how to parse

only does this for unqualified names if a committish isn't supplied, i.e.
doesn't override '#develop' in 'typescript#develop'
 2018-10-22 19:43:16 +02:00
Jonathan Rainville d7cd3a72c9
add message at the end of the first ouput 2018-10-22 19:43:15 +02:00
Jonathan Rainville 9c0bff4515
remove console dir that I forgot to remove 2018-10-22 19:40:52 +02:00
Pascal Precht 80c80e9beb
fix(commands/build): don't start blockchain node when `--contracts` is used 
Prior to this commit `$ embark build --contracts` spinned up a blockchain node
which is not necessary as `--contracts` can be seen as a "compile only" option.

This commit ensures we don't start any web3 services with `--contracts` is used.
 2018-10-22 19:40:52 +02:00
Michael Bradley, Jr fd856f8163
PKG_PATH, pkgPath 2018-10-22 19:39:26 +02:00
hodlbank f41bcd55d6
[f] Fix for #971 - "Fatal error when Ethereum node going offline". 
[a] Added .once() into Events.
 2018-10-22 19:39:26 +02:00
Moksh Jain 08c140b035
added webserver logging 2018-10-22 19:39:25 +02:00
Moksh Jain 51b2cce0ea
adds dashboard logging for: geth, ipfs, swarm 2018-10-22 19:39:25 +02:00
Subramanian Venkatesan ee77ac7f7f
Adds solc option to tests. Runs smart contract tests using remix-tests 
Ref: #817
 2018-10-22 19:39:24 +02:00
Jonathan Rainville f71c158164
change 70000 for a constant 2018-10-22 19:35:59 +02:00
Pascal Precht d34428a129
refactor(modules/pipeline/webpackProcess): load pipeline config in Config class 
to configure pipeline specific options like TypeScript support.

At the time this has been added, `core/config` didn't handle the loading
of configuration files for pipeline related tasks yet.

This commit ensures a dapp's `pipeline.json` will be loaded and used to
configure Embark's webpack process as part of Embark's `Config` initialization.
 2018-10-22 19:35:59 +02:00
Pascal Precht 71e92358a8
feat(modules/watcher): introduce watcher plugin module 
As part of a bigger refactoring to make Embark's build pipeline pluggable,
this commit moves the watcher into its own plugin module so it can be
consumed via Embark's event bus.

It also introduces new command handlers for all watcher related APIs respectively:

- watcher:start
- watcher:stop
- watcher:restart
 2018-10-22 19:35:58 +02:00
Pascal Precht 081b7eee89
chore(blockchainProcess): improve error message when blockchain client exits early 
In cases a blockchain client exits before Embark is done doing its work,
the current error message doesn't provide any pointers to why this
happened.

Running `$ embark blockchain` separately could yield more information by
the underlying process.
 2018-10-22 19:35:58 +02:00
Jonathan Rainville 5f8ad923c7
use an event to get web3 instead of global 2018-10-22 19:35:58 +02:00
Pascal Precht a0ef234fea
feat(modules/pipeline): move pipeline into its own module plugin 
This is the first step of refactoring Embark's pipeline abstraction into
dedicated plugin modules that take advantage of Embark's event system.

With this commit we're moving `Pipeline` into `lib/modules/pipeline` and
introduce a new command handler `pipeline:build`. Embark's engine now
requests builds via this command handler.

Notice that `Watch` still lives in `lib/pipeline` as this is a step-by-step
refactoring to reduce chances of introducing regressions.
 2018-10-22 19:35:58 +02:00
Jonathan Rainville 6b4321874b
add helpful messages when ens register is rejected 2018-10-22 19:35:58 +02:00
Jonathan Rainville 623bdc50ae
make on deploy manual 2018-10-22 19:35:57 +02:00
Cryptomental bcc1711061
contract_deployer: Redeploy if track field is set to false. 
Always deploy the contract regardless if already deployed
when 'track' field in the contract configuration is specified
and set to false.

In line with #938 requirements:

* If a contract has the track field set to false, that contract
  will always deploy.
* If the track field is set to true, then the existing deployment
  tracking mechanism will be active for that contract.
* If the field is not set, it should be assumed to true by default

Refs: https://github.com/embark-framework/embark/issues/938
 2018-10-22 19:35:57 +02:00
Michael Bradley, Jr 115bf1387d
fix chunking problem related to dynamic import and bug re: umd 2018-10-22 19:35:57 +02:00
Michael Bradley, Jr 0c60d2e1b4
per latest babel-preset-react-app exclue transform-typeof-symbol 2018-10-22 19:35:57 +02:00
Michael Bradley, Jr b971f5bcec
in comments provide links to relevant tag not a commit 2018-10-22 19:35:57 +02:00
Michael Bradley, Jr e7aa9de8f3
TODO comment re: pipeline config 2018-10-22 19:35:56 +02:00
Michael Bradley, Jr a898bbdf18
don't waste time gzip'ing contents of babel-loader's cache 2018-10-22 19:35:56 +02:00