embark

Author SHA1 Message Date

Author	SHA1	Message	Date
Michael Bradley, Jr	9f2a5949c2	build: specify missing test action in relevant package.json "qa" scripts It's a relevant `package.json` if the package has a test suite. If `test` isn't specified then the tests won't run in CI (they have't been running). Include a fix for one failing test in `packages/plugins/ens` and two failing test in `packages/stack/deployment`. In all three cases, the mock embark object's config needed a `blockchainConfig` section with `{ enabled: true }`.	2019-12-11 14:01:12 -06:00
Pascal Precht	9df24309e7	fix(@embark/ens): fix broken test due to async API As part of `8ed5376533` we made `ENS.getEnsConfig()` asynchronous, hence it needs a callback. This change was not done in one of the ENS tests, resulting in the test to fail. The test mocked that particular API, turning it into noop, which is why the test kept timing out. This commit fixes the test by not mocking the API and adding the needed configuration to the environment.	2019-12-11 11:34:27 -05:00
Jonathan Rainville	6f90099d47	Add tests for ENS (#1933 ) * add basic test to ens * add more tests * test arguments for test	2019-10-12 11:42:16 +09:00

Michael Bradley, Jr

9f2a5949c2

build: specify missing test action in relevant package.json "qa" scripts

It's a relevant `package.json` if the package has a test suite. If `test` isn't
specified then the tests won't run in CI (they have't been running).

Include a fix for one failing test in `packages/plugins/ens` and two failing
test in `packages/stack/deployment`. In all three cases, the mock embark
object's config needed a `blockchainConfig` section with `{ enabled: true }`.

2019-12-11 14:01:12 -06:00

Pascal Precht

9df24309e7

fix(@embark/ens): fix broken test due to async API

As part of 8ed5376533 we made `ENS.getEnsConfig()`
asynchronous, hence it needs a callback. This change was not done in one of the
ENS tests, resulting in the test to fail. The test mocked that particular API,
turning it into noop, which is why the test kept timing out.

This commit fixes the test by not mocking the API and adding the needed configuration
to the environment.

2019-12-11 11:34:27 -05:00

Jonathan Rainville

6f90099d47

Add tests for ENS (#1933 )

* add basic test to ens

* add more tests

* test arguments for test

2019-10-12 11:42:16 +09:00

3 Commits