Commit Graph

2727 Commits

Author SHA1 Message Date
Iuri Matias b62c9dcd38
Merge pull request #532 from embark-framework/bug_fix/contract-breaks-pipeline
Fix for starting embark with a contract that has an error, then fixing, seems to still break the pipeline
2018-06-15 17:50:02 -04:00
Iuri Matias 4beb320385 fix package lock 2018-06-15 17:45:08 -04:00
Iuri Matias c9ad938c9a fix package lock 2018-06-15 17:43:25 -04:00
Iuri Matias 1766401583 remove duplicated require 2018-06-15 17:33:26 -04:00
emizzle 15faf3a336 Fix for starting embark with a contract that has an error, then fixing, seems to still break the pipeline.
Needed to reset the `compileError` flag once compilation succeeded.
2018-06-15 17:31:17 -04:00
Iuri Matias 1acea7b178 lock version to avoid suprises 2018-06-15 17:31:17 -04:00
Iuri Matias b0daf96865 use neo-blessed 2018-06-15 17:31:17 -04:00
Eric Mastro 286848030c package-lock conflict 2018-06-15 17:31:17 -04:00
Iuri Matias 043ac87d80 use neo-blessed 2018-06-15 17:29:19 -04:00
Iuri Matias 5614998f89
Merge pull request #525 from embark-framework/bug_fix/solc-loading-issue
Fix for solc loading issue
2018-06-15 17:28:53 -04:00
Iuri Matias 440593f9f0
Merge pull request #539 from embark-framework/bug_fix/simple-app-watch
fix watch for simple apps
2018-06-15 17:24:55 -04:00
Iuri Matias 6b11fb9e45
Merge pull request #540 from embark-framework/profilerErrorLogFix
small fixes to ensure something of a better experience for error reports
2018-06-15 17:24:35 -04:00
Iuri Matias 6845c7124b fix eqls 2018-06-15 17:24:19 -04:00
emizzle ffe0157543 removed unneeded comment 2018-06-15 17:06:59 -04:00
emizzle 279e63e3d8 package-lock conflict fix 2018-06-15 17:06:59 -04:00
emizzle 79ca004de6 remove .vscode launch tasks and fix package-lock conflict. 2018-06-15 17:06:59 -04:00
emizzle a100dd4260 Requested PR fixes
Added catch to live-plugin-manager install promise running in child process

Removed some `else`'s ;)

Only showing solc downloading spinner when `--nodashboard` option is used.

When installing package in main process and simultaneous downloads fail, all callbacks called with error.

Updated logging in npmTimer.
2018-06-15 17:06:59 -04:00
Eric Mastro 4604ac2aa2 Remove .vscode launch config 2018-06-15 17:06:59 -04:00
emizzle 5e20f27c99 Solc loading issue now fully resolved
Added better error checking for solidity compilation errors

Extracted timer functionality for downloading packages so it works across the main process and child processes.

Npm class is instantiated only once and reused for event commands.

Npm class can handle concurrent requests for the same package and callback the installation result for each request.
2018-06-15 17:06:59 -04:00
Eric Mastro 6033617f5c package-lock conflict 2018-06-15 17:06:59 -04:00
emizzle 6d6c398a6d Finally fixed the solc loading issue.
Moved the instantiation of the live-plugin-manager in to the child solc process. This allowed us to use the live-plugin-manager to require the installed solc file.

If the module is the same version as used by embark, the module is still loading using the normal require (from node_modules), as before.
2018-06-15 17:06:59 -04:00
Iuri Matias 49b15d020e lock version to avoid suprises 2018-06-15 17:06:59 -04:00
Iuri Matias 16cb513e34 use neo-blessed 2018-06-15 17:06:59 -04:00
Iuri Matias 4100ab87e0 update references to package 2018-06-15 17:06:59 -04:00
Iuri Matias 6730322784 point to a forked npm package (for now), to avoid the npm install issues some users are reporting 2018-06-15 17:06:59 -04:00
emizzle b96df79c59 Finally fixed the solc loading issue.
Moved the instantiation of the live-plugin-manager in to the child solc process. This allowed us to use the live-plugin-manager to require the installed solc file.

If the module is the same version as used by embark, the module is still loading using the normal require (from node_modules), as before.
2018-06-15 17:06:59 -04:00
Iuri Matias 4c16d7dd08 lock version to avoid suprises 2018-06-15 17:02:54 -04:00
Iuri Matias 0ca9446a4c use neo-blessed 2018-06-15 17:02:54 -04:00
Iuri Matias a75dded16d update references to package 2018-06-15 17:02:54 -04:00
Iuri Matias 5f839a829b point to a forked npm package (for now), to avoid the npm install issues some users are reporting 2018-06-15 17:02:54 -04:00
Eric Mastro 94d3a121a9 Remove .vscode launch config 2018-06-15 17:02:54 -04:00
emizzle ceb57cfdf6 removed unneeded log message 2018-06-15 17:02:54 -04:00
emizzle eedcdc77a7 Solc loading issue now fully resolved
Added better error checking for solidity compilation errors

Extracted timer functionality for downloading packages so it works across the main process and child processes.

Npm class is instantiated only once and reused for event commands.

Npm class can handle concurrent requests for the same package and callback the installation result for each request.
2018-06-15 17:02:53 -04:00
Eric Mastro a046acb732 package-lock conflict 2018-06-15 17:02:53 -04:00
Iuri Matias daf2eba36d lock version to avoid suprises 2018-06-15 16:58:39 -04:00
Iuri Matias c367ac2c88 use neo-blessed 2018-06-15 16:58:39 -04:00
Iuri Matias 6946883490 point to a forked npm package (for now), to avoid the npm install issues some users are reporting 2018-06-15 16:56:41 -04:00
emizzle 62f3b85bc4 Finally fixed the solc loading issue.
Moved the instantiation of the live-plugin-manager in to the child solc process. This allowed us to use the live-plugin-manager to require the installed solc file.

If the module is the same version as used by embark, the module is still loading using the normal require (from node_modules), as before.
2018-06-15 16:54:08 -04:00
Iuri Matias 5ee9843973
Merge pull request #541 from embark-framework/bug_fix/testnet-hang
remove deprecated geth params
2018-06-15 16:46:16 -04:00
Jonathan Rainville 7d94e4efee fix tests 2018-06-15 16:40:27 -04:00
Iuri Matias dae9e4ae7f
Merge pull request #460 from embark-framework/fix_overridecompiler
Allow plugins to override core compilers
2018-06-15 16:39:09 -04:00
Jonathan Rainville d77083ee8c enable syncMode 2018-06-15 16:33:59 -04:00
Jonathan Rainville 26447c9362 remove deprecated geth params 2018-06-15 16:23:55 -04:00
VoR0220 ad6a6cf328 small fixes to ensure something of a better experience for error reporting on the profiler side
Signed-off-by: VoR0220 <catalanor0220@gmail.com>
2018-06-15 15:22:27 -05:00
Jonathan Rainville e9becec515 sorry senior lint 2018-06-15 15:58:19 -04:00
Jonathan Rainville 2996f51314 fix watch for simple apps 2018-06-15 15:50:23 -04:00
Jonathan Rainville eb0ccbe7cc remove useless param 2018-06-15 15:22:06 -04:00
Jonathan Rainville 55bd69baa5 rmeove logs 2018-06-15 15:18:39 -04:00
Jonathan Rainville f32ac90e71 enable connecting to ws node in tests 2018-06-15 15:16:55 -04:00
RJ Catalano 6ea395ca76
Merge pull request #537 from embark-framework/gethFixes
Geth fixes
2018-06-15 14:11:24 -05:00