embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-02-18 00:27:17 +00:00
Code Issues Projects Releases Wiki Activity

fix(@embark/cockpit): Fix decode transaction error

Browse Source 
Reproduce:
1. Go to cockpit > transactions
2. Click a transaction
3. There will be a flicker of an error, then the decoded tx displays OK. Inspecting the network requests, there is a 500 error with a response of
```
AssertionError [ERR_ASSERTION]: invalid remainder
```
This error is also printed in the console.

The issue is that the transaction is not a raw transaction, so instead of trying to decode the non-raw transaction, the transaction can be decoded by web3.
This commit is contained in:
emizzle 2019-02-25 12:02:43 +11:00 committed by Eric Mastro
parent 9bd33a9de5
commit f957ba55dd
4 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/embark-ui/src/actions/index.js
View File

@ -1,6 +1,3 @@
import {EMBARK_PROCESS_NAME} from '../constants';
import {ansiToHtml} from '../utils/utils';
export const REQUEST = 'REQUEST'; export const REQUEST = 'REQUEST';
export const SUCCESS = 'SUCCESS'; export const SUCCESS = 'SUCCESS';
export const FAILURE = 'FAILURE'; export const FAILURE = 'FAILURE';

4
packages/embark-ui/src/components/ContractsDeployment.js
View File

@ -54,8 +54,8 @@ const LayoutContract = ({contract, children, cardTitle}) => (
LayoutContract.propTypes = { LayoutContract.propTypes = {
contract: PropTypes.object, contract: PropTypes.object,
children: PropTypes.array, children: PropTypes.any,
cardTitle: PropTypes.object cardTitle: PropTypes.any
}; };
const DeploymentResult = ({deployment}) => { const DeploymentResult = ({deployment}) => {

9
packages/embark-ui/src/services/web3.js
View File

@ -21,13 +21,12 @@ export function estimateGas({web3, contract, args}) {
export function deploy({web3, contract, args}) { export function deploy({web3, contract, args}) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
const cleanup = () => { promiEvent.removeAllListeners(); }; new web3.eth.Contract(contract.abiDefinition)
const promiEvent = new web3.eth.Contract(contract.abiDefinition)
.deploy({data: `0x${contract.code}`, arguments: args}) .deploy({data: `0x${contract.code}`, arguments: args})
.send({from: web3.eth.defaultAccount}) .send({from: web3.eth.defaultAccount})
.on('error', reject) .on('error', reject)
.on('receipt', resolve) .once('receipt', resolve)
.then(cleanup) .catch(reject)
.catch(cleanup); .then(() => {});
}); });
} }

2
packages/embark/src/lib/modules/blockchain_connector/index.js
View File

@ -419,7 +419,7 @@ class BlockchainConnector {
'get', 'get',
'/embark-api/blockchain/transactions/:hash', '/embark-api/blockchain/transactions/:hash',
(req, res) => { (req, res) => {
self.getTransactionByRawTransactionHash(req.params.hash, (err, transaction) => { self.getTransactionByHash(req.params.hash, (err, transaction) => {
if (err) { if (err) {
self.logger.error(err); self.logger.error(err);
} }