embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-02-20 01:18:52 +00:00
Code Issues Projects Releases Wiki Activity

refactor(embark-ui): filter silent contracts from contracts listings (#1444)

Browse Source 
Filter silent contracts in the views that display contracts lists rather than
with `formatContractForDisplay` because the old approach prevents interaction
with a silent contract if a link to it is followed from the blocks or
transactions explorer, which is not desirable.
This commit is contained in:
Michael Bradley 2019-03-15 15:22:15 -05:00 committed by André Medeiros
parent 9afdbd9848
commit f60c979c75
4 changed files with 45 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/embark-ui/src/components/Contracts.js
View File

@ -15,7 +15,9 @@ const Contracts = ({contracts, title = "Contracts"}) => (
</CardHeader> </CardHeader>
<CardBody> <CardBody>
{ {
contracts.map((contract, key) => { contracts
.filter(contract => !contract.silent)
.map((contract, key) => {
const contractDisplay = formatContractForDisplay(contract); const contractDisplay = formatContractForDisplay(contract);
if (!contractDisplay) { if (!contractDisplay) {
return ''; return '';

4
packages/embark-ui/src/components/ContractsList.js
View File

@ -15,7 +15,9 @@ const ContractsList = ({contracts}) => (
</thead> </thead>
<tbody> <tbody>
{ {
contracts.map((contract) => { contracts
.filter(contract => !contract.silent)
.map((contract) => {
const contractDisplay = formatContractForDisplay(contract); const contractDisplay = formatContractForDisplay(contract);
if (!contractDisplay) { if (!contractDisplay) {
return null; return null;

3
packages/embark-ui/src/utils/presentation.js
View File

@ -1,7 +1,4 @@
export function formatContractForDisplay(contract) { export function formatContractForDisplay(contract) {
if (contract.silent) {
return;
}
let address = (contract.address || contract.deployedAddress); let address = (contract.address || contract.deployedAddress);
let state = 'Deployed'; let state = 'Deployed';
let stateColor = 'success'; let stateColor = 'success';