embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Removing code. Doesn't make sense to specify keys when everyone can read them

This commit is contained in:
Richard Ramos 2018-07-16 10:32:55 -04:00 committed by Iuri Matias
parent 57f71d5504
commit f56fd9e264
4 changed files with 8 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/modules/whisper/index.js
View File

@ -73,7 +73,7 @@ class Whisper {
addSetProvider() {
let connection = this.communicationConfig.connection || {};
let keys = this.communicationConfig.keys || {};
// todo: make the add code a function as well
let config = JSON.stringify({
server: canonicalHost(connection.host || defaultHost),
@ -84,7 +84,7 @@ class Whisper {
if (keys.symmetricKey) {
config.symKey = keys.symmetricKey;
}
if (keys.privateKey) {
config.privateKey = keys.privateKey;
}

27
lib/modules/whisper/js/embarkjs.js
View File

@ -17,27 +17,12 @@ __embarkWhisperNewWeb3.setProvider = function (options) {
if (err) {
console.log("whisper not available");
} else if (version >= 5) {
if (options.symKey) {
self.web3.shh.addSymKey(options.symKey).then(id => {
self.symKeyID = id;
});
} else {
self.web3.shh.newSymKey().then((id) => {
self.symKeyID = id;
});
}
if (options.privateKey) {
self.web3.shh.addPrivateKey(options.privateKey).then((id) => {
self.sig = id;
});
} else {
self.web3.shh.newKeyPair().then((id) => {
self.sig = id;
});
}
self.web3.shh.newSymKey().then((id) => {
self.symKeyID = id;
});
self.web3.shh.newKeyPair().then((id) => {
self.sig = id;
});
} else {
throw new Error("version of whisper not supported");
}

7
templates/boilerplate/config/communication.js
View File

@ -8,13 +8,6 @@ module.exports = {
port: 8546, // Port of the blockchain node
type: "ws" // Type of connection (ws or rpc)
}
// Use this section when you need a specific symmetric or private keys in whisper
/*
,keys: {
symmetricKey: "your_symmetric_key",// Symmetric key for message decryption
privateKey: "your_private_key" // Private Key to be used as a signing key and for message decryption
}
*/
}
};

7
templates/demo/config/communication.js
View File

@ -8,12 +8,5 @@ module.exports = {
port: 8546, // Port of the blockchain node
type: "ws" // Type of connection (ws or rpc)
}
// Use this section when you need a specific symmetric or private keys in whisper
/*
,keys: {
symmetricKey: "your_symmetric_key",// Symmetric key for message decryption
privateKey: "your_private_key" // Private Key to be used as a signing key and for message decryption
}
*/
}
};