From f5479baf4c3740b05922d5230563f9b1e5e659b8 Mon Sep 17 00:00:00 2001 From: Iuri Matias Date: Sun, 14 Oct 2018 13:22:51 -0400 Subject: [PATCH] fix misc issues reported by linter --- embark-ui/src/components/Console.js | 4 ---- embark-ui/src/reducers/index.js | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/embark-ui/src/components/Console.js b/embark-ui/src/components/Console.js index 2a9fb6966..f8f4219d9 100644 --- a/embark-ui/src/components/Console.js +++ b/embark-ui/src/components/Console.js @@ -77,8 +77,6 @@ class Console extends Component { } render() { - const {value} = this.state; - return ( @@ -93,7 +91,6 @@ class Console extends Component { emptyLabel={false} labelKey="value" multiple={false} - emptyLabel={false} maxResults={10} isLoading={this.state.isLoading} onInputChange={(text) => this.handleChange(text)} @@ -118,7 +115,6 @@ class Console extends Component { maxHeight="200px" placeholder="Type a command (e.g help)" options={this.props.command_suggestions} - placeholder="Choose a state..." renderMenuItemChildren={(option) => (
{option.value} diff --git a/embark-ui/src/reducers/index.js b/embark-ui/src/reducers/index.js index cc94a0bc0..32dc2334c 100644 --- a/embark-ui/src/reducers/index.js +++ b/embark-ui/src/reducers/index.js @@ -48,7 +48,7 @@ const sorter = { let a_levels = a.value.split('.').length let b_levels = b.value.split('.').length let diff = b_levels - a_levels - if (diff !== 0) return lengthDiff * -1 + if (diff !== 0) return diff * -1 } let lengthDiff = b.value.length - a.value.length; if (lengthDiff !== 0) return lengthDiff * -1