embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(cmd-controller): fix build --contracts command starting comm node 

Fixes https://github.com/embarklabs/embark/issues/2288
Only start a blockchain node when there is no --contracts flag and
start only needed modules for compilation
This commit is contained in:
Jonathan Rainville 2020-02-24 08:47:30 -05:00 committed by Iuri Matias
parent 584845b220
commit e99a32887d
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
packages/embark/src/cmd/cmd_controller.js
View File

@ -291,15 +291,14 @@ class EmbarkController {
engine.registerModuleGroup("compiler");
engine.registerModuleGroup("contracts");
engine.registerModuleGroup("pipeline");
engine.registerModuleGroup("communication");
engine.registerModuleGroup("namesystem");
engine.registerModulePackage('embark-deploy-tracker', { plugins: engine.plugins });
engine.registerModuleGroup("blockchain");
if (!options.onlyCompile) {
engine.registerModuleGroup("blockchain");
engine.registerModuleGroup("namesystem");
engine.registerModuleGroup("storage");
engine.registerModuleGroup("communication");
engine.registerModuleGroup("pipeline");
engine.registerModulePackage('embark-deploy-tracker', { plugins: engine.plugins });
}
// load custom plugins
@ -311,6 +310,9 @@ class EmbarkController {
let plugin = engine.plugins.createPlugin('cmdcontrollerplugin', {});
plugin.registerActionForEvent("embark:engine:started", async (_, cb) => {
if (options.onlyCompile) {
return cb();
}
try {
await Promise.all([
engine.events.request2("blockchain:node:start", engine.config.blockchainConfig),
@ -382,8 +384,8 @@ class EmbarkController {
await engine.events.request2("deployment:contracts:deploy", contractsList, contractDependencies);
await engine.events.request2('scripts-runner:initialize');
await engine.events.request2('scripts-runner:execute', options.target, options.forceTracking);
} catch (err) {
return callback(err);
} catch (e) {
return callback(e);
}
callback();
});